mirror of
https://github.com/curl/curl.git
synced 2026-04-12 00:11:42 +08:00
ce4db9c2ef
`scan-build` is a (Perl) wrapper around clang's built-in `--analyze`
option. Which look similar or identical to clang-tidy checkers under
the `clang-analyzer-*` namespace:
https://clang.llvm.org/docs/ClangStaticAnalyzer.html
Unless somebody has other information, it appears redundant to run
scan-build in parallel with clang-tidy in CI, now that the latter is
working reliably and with good performance for all curl components.
Another scan-build issue is the lack of a markup to suppress false
positives. It ignores `NOLINT`, yet finds the same false positives as
clang-tidy. This happens with scan-build v20+. v18 is silent, but it's
a blocker to upgrade to a newer version.
scan-build may still be a useful when combined with autotools, where
clang-tidy support is incomplete, slow (no parallelism), and uses
a distinct make target, which does not build binaries in the same pass.
But, scan-build also lacks extra checkers that are now enabled for
clang-tidy.
The clang-tidy job is also 30-40s faster than the one it replaced.
Also:
- drop scan-build job configured the same way as a clang-tidy one.
CI time saved: 6m30s
- bump to clang-20 (from 18) in the replacement job.
- build tests in the replacement job.
To verify a cmake command-line reconstruction issue only hit in this
job in CI.
CI time cost: 1m40s
- replacement job caught a minor, new, issue.
Ref:
|
||
|---|---|---|
| .. | ||
| appveyor-status.yml | ||
| checkdocs.yml | ||
| checksrc.yml | ||
| checkurls.yml | ||
| codeql.yml | ||
| configure-vs-cmake.yml | ||
| curl-for-win.yml | ||
| distcheck.yml | ||
| fuzz.yml | ||
| http3-linux.yml | ||
| label.yml | ||
| linux-old.yml | ||
| linux.yml | ||
| macos.yml | ||
| non-native.yml | ||
| windows.yml | ||