mirror of
https://github.com/curl/curl.git
synced 2026-04-13 00:31:41 +08:00
Make test bundles the default. Drop non-bundle build mode.
Also do all the optimizations and tidy-ups this allows, simpler builds,
less bundle exceptions, streamlined build mechanics.
Also rework the init/deinit macro magic for unit tests. The new method
allows using unique init/deinit function names, and calling them with
arguments. This is in turn makes it possible to reduce the use of global
variables.
Note this drop existing build options `-DCURL_TEST_BUNDLES=` from cmake
and `--enable-test-bundles` / `--disable-test-bundles` from autotools.
Also:
- rename test entry functions to have unique names: `test_<testname>`
This removes the last exception that was handled in the generator.
- fix `make dist` to not miss test sources with test bundles enabled.
- sync and merge `tests/mk-bundle.pl` into `scripts/mk-unity.pl`.
- mk-unity.pl: add `--embed` option and use it when `CURL_CLANG_TIDY=ON`
to ensure that `clang-tidy` does not miss external test C sources.
(because `clang-tidy` ignores code that's #included.)
- tests/unit: drop no-op setup/stop functions.
- tests: reduce symbol scopes, global macros, other fixes and tidy-ups.
- tool1621: fix to run, also fix it to pass.
- sockfilt: fix Windows compiler warning in certain unity include order,
by explicitly including `warnless.h`.
Follow-up to 6897aeb105 #17468
Closes #17590
177 lines
5.0 KiB
C
177 lines
5.0 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
/*
|
|
* This code sets up multiple easy handles that transfer a single file from
|
|
* the same URL, in a serial manner after each other. Due to the connection
|
|
* sharing within the multi handle all transfers are performed on the same
|
|
* persistent connection.
|
|
*
|
|
* This source code is used for test526, test527 and test532 with branches
|
|
* controlling the small differences.
|
|
*
|
|
* - test526 closes all easy handles after
|
|
* they all have transferred the file over the single connection
|
|
* - test527 closes each easy handle after each single transfer.
|
|
* - test532 uses only a single easy handle that is removed, reset and then
|
|
* re-added for each transfer
|
|
*
|
|
* Test case 526, 527 and 532 use FTP, while test 528 uses the lib526 tool but
|
|
* with HTTP.
|
|
*/
|
|
|
|
#include "test.h"
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include "testutil.h"
|
|
#include "warnless.h"
|
|
#include "memdebug.h"
|
|
|
|
static CURLcode test_lib526(char *URL)
|
|
{
|
|
CURLcode res = CURLE_OK;
|
|
CURL *curl[NUM_HANDLES];
|
|
int running;
|
|
CURLM *m = NULL;
|
|
size_t current = 0;
|
|
size_t i;
|
|
|
|
for(i = 0; i < CURL_ARRAYSIZE(curl); i++)
|
|
curl[i] = NULL;
|
|
|
|
start_test_timing();
|
|
|
|
global_init(CURL_GLOBAL_ALL);
|
|
|
|
/* get each easy handle */
|
|
for(i = 0; i < CURL_ARRAYSIZE(curl); i++) {
|
|
easy_init(curl[i]);
|
|
/* specify target */
|
|
easy_setopt(curl[i], CURLOPT_URL, URL);
|
|
/* go verbose */
|
|
easy_setopt(curl[i], CURLOPT_VERBOSE, 1L);
|
|
}
|
|
|
|
multi_init(m);
|
|
|
|
multi_add_handle(m, curl[current]);
|
|
|
|
curl_mfprintf(stderr, "Start at URL 0\n");
|
|
|
|
for(;;) {
|
|
struct timeval interval;
|
|
fd_set rd, wr, exc;
|
|
int maxfd = -99;
|
|
|
|
interval.tv_sec = 1;
|
|
interval.tv_usec = 0;
|
|
|
|
multi_perform(m, &running);
|
|
|
|
abort_on_test_timeout();
|
|
|
|
if(!running) {
|
|
if(testnum == 527) {
|
|
/* NOTE: this code does not remove the handle from the multi handle
|
|
here, which would be the nice, sane and documented way of working.
|
|
This however tests that the API survives this abuse gracefully. */
|
|
curl_easy_cleanup(curl[current]);
|
|
curl[current] = NULL;
|
|
}
|
|
if(++current < CURL_ARRAYSIZE(curl)) {
|
|
curl_mfprintf(stderr, "Advancing to URL %d\n", (int)current);
|
|
if(testnum == 532) {
|
|
/* first remove the only handle we use */
|
|
curl_multi_remove_handle(m, curl[0]);
|
|
|
|
/* make us reuse the same handle all the time, and try resetting
|
|
the handle first too */
|
|
curl_easy_reset(curl[0]);
|
|
easy_setopt(curl[0], CURLOPT_URL, URL);
|
|
/* go verbose */
|
|
easy_setopt(curl[0], CURLOPT_VERBOSE, 1L);
|
|
|
|
/* re-add it */
|
|
multi_add_handle(m, curl[0]);
|
|
}
|
|
else {
|
|
multi_add_handle(m, curl[current]);
|
|
}
|
|
}
|
|
else {
|
|
break; /* done */
|
|
}
|
|
}
|
|
|
|
FD_ZERO(&rd);
|
|
FD_ZERO(&wr);
|
|
FD_ZERO(&exc);
|
|
|
|
multi_fdset(m, &rd, &wr, &exc, &maxfd);
|
|
|
|
/* At this point, maxfd is guaranteed to be greater or equal than -1. */
|
|
|
|
select_test(maxfd + 1, &rd, &wr, &exc, &interval);
|
|
|
|
abort_on_test_timeout();
|
|
}
|
|
|
|
test_cleanup:
|
|
|
|
if((testnum == 526) || (testnum == 528)) {
|
|
/* proper cleanup sequence - type PB */
|
|
|
|
for(i = 0; i < CURL_ARRAYSIZE(curl); i++) {
|
|
curl_multi_remove_handle(m, curl[i]);
|
|
curl_easy_cleanup(curl[i]);
|
|
}
|
|
curl_multi_cleanup(m);
|
|
curl_global_cleanup();
|
|
}
|
|
else if(testnum == 527) {
|
|
/* Upon non-failure test flow the easy's have already been cleanup'ed. In
|
|
case there is a failure we arrive here with easy's that have not been
|
|
cleanup'ed yet, in this case we have to cleanup them or otherwise these
|
|
will be leaked, let's use undocumented cleanup sequence - type UB */
|
|
|
|
if(res != CURLE_OK)
|
|
for(i = 0; i < CURL_ARRAYSIZE(curl); i++)
|
|
curl_easy_cleanup(curl[i]);
|
|
|
|
curl_multi_cleanup(m);
|
|
curl_global_cleanup();
|
|
|
|
}
|
|
else if(testnum == 532) {
|
|
/* undocumented cleanup sequence - type UB */
|
|
|
|
for(i = 0; i < CURL_ARRAYSIZE(curl); i++)
|
|
curl_easy_cleanup(curl[i]);
|
|
curl_multi_cleanup(m);
|
|
curl_global_cleanup();
|
|
}
|
|
|
|
return res;
|
|
}
|