mirror of
https://github.com/curl/curl.git
synced 2026-04-13 12:41:42 +08:00
Make test bundles the default. Drop non-bundle build mode.
Also do all the optimizations and tidy-ups this allows, simpler builds,
less bundle exceptions, streamlined build mechanics.
Also rework the init/deinit macro magic for unit tests. The new method
allows using unique init/deinit function names, and calling them with
arguments. This is in turn makes it possible to reduce the use of global
variables.
Note this drop existing build options `-DCURL_TEST_BUNDLES=` from cmake
and `--enable-test-bundles` / `--disable-test-bundles` from autotools.
Also:
- rename test entry functions to have unique names: `test_<testname>`
This removes the last exception that was handled in the generator.
- fix `make dist` to not miss test sources with test bundles enabled.
- sync and merge `tests/mk-bundle.pl` into `scripts/mk-unity.pl`.
- mk-unity.pl: add `--embed` option and use it when `CURL_CLANG_TIDY=ON`
to ensure that `clang-tidy` does not miss external test C sources.
(because `clang-tidy` ignores code that's #included.)
- tests/unit: drop no-op setup/stop functions.
- tests: reduce symbol scopes, global macros, other fixes and tidy-ups.
- tool1621: fix to run, also fix it to pass.
- sockfilt: fix Windows compiler warning in certain unity include order,
by explicitly including `warnless.h`.
Follow-up to 6897aeb105 #17468
Closes #17590
157 lines
3.9 KiB
C
157 lines
3.9 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
/*
|
|
* This source code is used for lib1502, lib1503, lib1504 and lib1505 with
|
|
* only the testnum controlling the cleanup sequence.
|
|
*
|
|
* Test case 1502 converted from bug report #3575448, identifying a memory
|
|
* leak in the CURLOPT_RESOLVE handling with the multi interface.
|
|
*/
|
|
|
|
#include "test.h"
|
|
|
|
#include <limits.h>
|
|
|
|
#include "testutil.h"
|
|
#include "warnless.h"
|
|
#include "memdebug.h"
|
|
|
|
static CURLcode test_lib1502(char *URL)
|
|
{
|
|
CURL *easy = NULL;
|
|
CURL *dup;
|
|
CURLM *multi = NULL;
|
|
int still_running;
|
|
CURLcode res = CURLE_OK;
|
|
char redirect[160];
|
|
|
|
/* DNS cache injection */
|
|
struct curl_slist *dns_cache_list;
|
|
|
|
res_global_init(CURL_GLOBAL_ALL);
|
|
if(res) {
|
|
return res;
|
|
}
|
|
|
|
curl_msnprintf(redirect, sizeof(redirect), "google.com:%s:%s", libtest_arg2,
|
|
libtest_arg3);
|
|
|
|
start_test_timing();
|
|
|
|
dns_cache_list = curl_slist_append(NULL, redirect);
|
|
if(!dns_cache_list) {
|
|
curl_mfprintf(stderr, "curl_slist_append() failed\n");
|
|
curl_global_cleanup();
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
easy_init(easy);
|
|
|
|
easy_setopt(easy, CURLOPT_URL, URL);
|
|
easy_setopt(easy, CURLOPT_HEADER, 1L);
|
|
easy_setopt(easy, CURLOPT_RESOLVE, dns_cache_list);
|
|
|
|
dup = curl_easy_duphandle(easy);
|
|
if(dup) {
|
|
curl_easy_cleanup(easy);
|
|
easy = dup;
|
|
}
|
|
else {
|
|
curl_slist_free_all(dns_cache_list);
|
|
curl_easy_cleanup(easy);
|
|
curl_global_cleanup();
|
|
return CURLE_OUT_OF_MEMORY;
|
|
}
|
|
|
|
multi_init(multi);
|
|
|
|
multi_add_handle(multi, easy);
|
|
|
|
multi_perform(multi, &still_running);
|
|
|
|
abort_on_test_timeout();
|
|
|
|
while(still_running) {
|
|
struct timeval timeout;
|
|
fd_set fdread;
|
|
fd_set fdwrite;
|
|
fd_set fdexcep;
|
|
int maxfd = -99;
|
|
|
|
FD_ZERO(&fdread);
|
|
FD_ZERO(&fdwrite);
|
|
FD_ZERO(&fdexcep);
|
|
timeout.tv_sec = 1;
|
|
timeout.tv_usec = 0;
|
|
|
|
multi_fdset(multi, &fdread, &fdwrite, &fdexcep, &maxfd);
|
|
|
|
/* At this point, maxfd is guaranteed to be greater or equal than -1. */
|
|
|
|
select_test(maxfd + 1, &fdread, &fdwrite, &fdexcep, &timeout);
|
|
|
|
abort_on_test_timeout();
|
|
|
|
multi_perform(multi, &still_running);
|
|
|
|
abort_on_test_timeout();
|
|
}
|
|
|
|
test_cleanup:
|
|
|
|
switch(testnum) {
|
|
case 1502:
|
|
default:
|
|
/* undocumented cleanup sequence - type UA */
|
|
curl_multi_cleanup(multi);
|
|
curl_easy_cleanup(easy);
|
|
curl_global_cleanup();
|
|
break;
|
|
case 1503:
|
|
/* proper cleanup sequence - type PA */
|
|
curl_multi_remove_handle(multi, easy);
|
|
curl_multi_cleanup(multi);
|
|
curl_easy_cleanup(easy);
|
|
curl_global_cleanup();
|
|
break;
|
|
case 1504:
|
|
/* undocumented cleanup sequence - type UB */
|
|
curl_easy_cleanup(easy);
|
|
curl_multi_cleanup(multi);
|
|
curl_global_cleanup();
|
|
break;
|
|
case 1505:
|
|
/* proper cleanup sequence - type PB */
|
|
curl_multi_remove_handle(multi, easy);
|
|
curl_easy_cleanup(easy);
|
|
curl_multi_cleanup(multi);
|
|
curl_global_cleanup();
|
|
break;
|
|
}
|
|
|
|
curl_slist_free_all(dns_cache_list);
|
|
|
|
return res;
|
|
}
|