mirror of
https://github.com/curl/curl.git
synced 2026-04-14 00:51:42 +08:00
6dc5f2948c
By passing to clang-tidy the C compiler with `--target` and sysroot
options, if any.
Fixing (GHA/windows, linux-mingw, CM clang-tidy):
```
lib/curl_setup.h:841:10: error: 'io.h' file not found [clang-diagnostic-error]
841 | #include <io.h>
| ^~~~~~
Found compiler error(s).
FAILED: [code=1] tests/server/CMakeFiles/servers-clang-tidy bld/tests/server/CMakeFiles/servers-clang-tidy
cd tests/server && /usr/bin/clang-tidy --config-file=.clang-tidy.yml
--warnings-as-errors=* --checks=-clang-diagnostic-unused-function first.c getpart.c util.c dnsd.c [...]
-- <-D-options> <-I-options> <cflags>
```
For reference, this is CMake's built-in clang-tidy invocation:
```
/usr/local/bin/cmake -E __run_co_compile --tidy="/usr/bin/clang-tidy;--config-file=.clang-tidy.yml;
--warnings-as-errors=*;--extra-arg-before=--driver-mode=gcc" --source=lib/curl_fopen.c
-- /usr/bin/clang --target=x86_64-w64-mingw32 <-D-options> <-I-options> <cflags>
```
Also:
- bump cmakelint `--max-statements`. Needs 59 after this patch.
- use undocumented CMake variables:
- `CMAKE_C_COMPILE_OPTIONS_TARGET` for `--target=`
- `CMAKE_C_COMPILE_OPTIONS_SYSROOT` for `--sysroot=`
Cherry-picked from #20631
Closes #20640
80 lines
3.1 KiB
Bash
Executable File
80 lines
3.1 KiB
Bash
Executable File
#!/bin/sh
|
|
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Dan Fandrich, <dan@coneharvesters.com>, Viktor Szakats, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
|
|
# https://cmake-format.readthedocs.io/en/latest/cmake-lint.html
|
|
# https://cmake-format.readthedocs.io/en/latest/lint-usage.html
|
|
# https://github.com/cheshirekow/cmake_format/blob/master/cmakelang/configuration.py
|
|
|
|
# Run cmakelint on the curl source code. It will check all files given on the
|
|
# command-line, or else all relevant files in git, or if not in a git
|
|
# repository, all files starting in the tree rooted in the current directory.
|
|
#
|
|
# cmake-lint can be installed from PyPi with the command "python3 -m pip
|
|
# install cmakelang".
|
|
#
|
|
# The xargs invocation is portable, but does not preserve spaces in filenames.
|
|
# If such a file is ever added, then this can be portably fixed by switching to
|
|
# "xargs -I{}" and appending {} to the end of the xargs arguments (which will
|
|
# call cmakelint once per file) or by using the GNU extension "xargs -d'\n'".
|
|
|
|
set -eu
|
|
|
|
cd "$(dirname "$0")"/..
|
|
|
|
{
|
|
if [ -n "${1:-}" ]; then
|
|
for A in "$@"; do printf '%s\n' "$A"; done
|
|
elif git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
|
|
git ls-files '**CMakeLists.txt' '*.cmake'
|
|
else
|
|
find . -type f \( -name 'CMakeLists.txt' -o -name '*.cmake' \)
|
|
fi
|
|
} | sort | xargs \
|
|
cmake-lint \
|
|
--suppress-decorations \
|
|
--disable \
|
|
--line-width 132 \
|
|
--tab-size 2 \
|
|
--use-tabchars false \
|
|
--disabled-codes C0113 \
|
|
--function-pattern 'curl_[0-9a-z_]+' \
|
|
--macro-pattern '(curl_[0-9a-z_]+|check_include_file_concat_curl)' \
|
|
--global-var-pattern '[A-Z][0-9A-Z_]+' \
|
|
--internal-var-pattern '_[a-z][0-9a-z_]+' \
|
|
--local-var-pattern '_[a-z][0-9a-z_]+' \
|
|
--private-var-pattern '_[0-9a-z_]+' \
|
|
--public-var-pattern '([A-Z][0-9A-Z_]+|[A-Z][A-Za-z0-9]+_FOUND|[a-z]+_SOURCES|prefix|exec_prefix|includedir|libdir|ssize_t|_FILE_OFFSET_BITS)' \
|
|
--argument-var-pattern '_[a-z][0-9a-z_]+' \
|
|
--keyword-pattern '[A-Z][0-9A-Z_]+' \
|
|
--max-conditionals-custom-parser 2 \
|
|
--min-statement-spacing 1 \
|
|
--max-statement-spacing 2 \
|
|
--max-returns 6 \
|
|
--max-branches 12 \
|
|
--max-arguments 5 \
|
|
--max-localvars 15 \
|
|
--max-statements 65 \
|
|
--
|