mirror of
https://github.com/curl/curl.git
synced 2026-04-14 00:51:42 +08:00
e95f509c66
Before this patch the signal handler called `logmsg()` which in turn
called `printf()` variants (internal implementations), and `FILE *`
functions, `localtime()`. Some of these called `malloc`/`free`, which
isn't supported in s signal handler. Replace them with `write` calls,
losing some logging functionality.
Also:
- De-dupe and move `STD*_FILENO` macros to `lib/curl_setup.h`. Revert
the `src` definition to point to `stderr`, instead of `tool_stderr`.
Follow-up to e5bb88b8f8 #11958
POSIX specs with list of functions allowed in a signal handler:
2004: https://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_04.html#tag_02_04_03
2017: https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_04_03
2024: https://pubs.opengroup.org/onlinepubs/9799919799/functions/V2_chap02.html#tag_16_04_03
Linux CI run with the thread sanitizer going crazy when
hitting the signal handler in test 1238 and 1242 (TFTP):
```
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=12582)
#0 malloc <null> (servers+0x5ed70)
#1 _IO_file_doallocate <null> (libc.so.6+0x851b4)
#2 formatf /home/runner/work/curl/curl/bld/tests/server/../../lib/../../lib/mprintf.c:886:9 (servers+0xdff77)
[...]
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=12582)
#0 free <null> (servers+0x5f453)
#1 fclose <null> (libc.so.6+0x8532f)
#2 logmsg /home/runner/work/curl/curl/bld/tests/server/../../../tests/server/util.c:134:5 (servers+0xe684d)
```
Ref: https://github.com/curl/curl/actions/runs/14118903372/job/39555309490?pr=16851
Closes #16852
118 lines
3.0 KiB
C
118 lines
3.0 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "test.h"
|
|
|
|
#include "warnless.h"
|
|
#include "memdebug.h"
|
|
|
|
CURLcode test(char *URL)
|
|
{
|
|
CURLcode res;
|
|
CURL *curl;
|
|
#ifdef LIB696
|
|
int transfers = 0;
|
|
#endif
|
|
|
|
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
|
fprintf(stderr, "curl_global_init() failed\n");
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
fprintf(stderr, "curl_easy_init() failed\n");
|
|
curl_global_cleanup();
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
test_setopt(curl, CURLOPT_URL, URL);
|
|
test_setopt(curl, CURLOPT_CONNECT_ONLY, 1L);
|
|
test_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
|
|
#ifdef LIB696
|
|
again:
|
|
#endif
|
|
|
|
res = curl_easy_perform(curl);
|
|
|
|
if(!res) {
|
|
/* we are connected, now get an HTTP document the raw way */
|
|
const char *request =
|
|
"GET /556 HTTP/1.1\r\n"
|
|
"Host: ninja\r\n\r\n";
|
|
const char *sbuf = request;
|
|
size_t sblen = strlen(request);
|
|
size_t nwritten = 0, nread = 0;
|
|
|
|
do {
|
|
char buf[1024];
|
|
|
|
if(sblen) {
|
|
res = curl_easy_send(curl, sbuf, sblen, &nwritten);
|
|
if(res && res != CURLE_AGAIN)
|
|
break;
|
|
if(nwritten > 0) {
|
|
sbuf += nwritten;
|
|
sblen -= nwritten;
|
|
}
|
|
}
|
|
|
|
/* busy-read like crazy */
|
|
res = curl_easy_recv(curl, buf, sizeof(buf), &nread);
|
|
|
|
if(nread) {
|
|
/* send received stuff to stdout */
|
|
#ifdef UNDER_CE
|
|
if((size_t)fwrite(buf, sizeof(buf[0]), nread, stdout) != nread) {
|
|
#else
|
|
if((size_t)write(STDOUT_FILENO, buf, nread) != nread) {
|
|
#endif
|
|
fprintf(stderr, "write() failed: errno %d (%s)\n",
|
|
errno, strerror(errno));
|
|
res = TEST_ERR_FAILURE;
|
|
break;
|
|
}
|
|
}
|
|
|
|
} while((res == CURLE_OK && nread) || (res == CURLE_AGAIN));
|
|
|
|
if(res && res != CURLE_AGAIN)
|
|
res = TEST_ERR_FAILURE;
|
|
}
|
|
|
|
#ifdef LIB696
|
|
++transfers;
|
|
/* perform the transfer a second time */
|
|
if(!res && transfers == 1)
|
|
goto again;
|
|
#endif
|
|
|
|
test_cleanup:
|
|
|
|
curl_easy_cleanup(curl);
|
|
curl_global_cleanup();
|
|
|
|
return res;
|
|
}
|