mirror of
https://github.com/curl/curl.git
synced 2026-04-14 13:01:42 +08:00
9465327084
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to72abf7c13a#13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up tofabfa8e402#15825 Closes #16756
99 lines
3.0 KiB
C
99 lines
3.0 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "test.h"
|
|
|
|
#include "testutil.h"
|
|
#include "warnless.h"
|
|
#include "memdebug.h"
|
|
|
|
/* The maximum string length limit (CURL_MAX_INPUT_LENGTH) is an internal
|
|
define not publicly exposed so we set our own */
|
|
#define MAX_INPUT_LENGTH 8000000
|
|
|
|
static char testbuf[MAX_INPUT_LENGTH + 2];
|
|
|
|
CURLcode test(char *URL)
|
|
{
|
|
const struct curl_easyoption *o;
|
|
CURL *easy;
|
|
int error = 0;
|
|
(void)URL;
|
|
|
|
curl_global_init(CURL_GLOBAL_ALL);
|
|
easy = curl_easy_init();
|
|
if(!easy) {
|
|
curl_global_cleanup();
|
|
return TEST_ERR_EASY_INIT;
|
|
}
|
|
|
|
/* make it a null-terminated C string with just As */
|
|
memset(testbuf, 'A', MAX_INPUT_LENGTH + 1);
|
|
testbuf[MAX_INPUT_LENGTH + 1] = 0;
|
|
|
|
printf("string length: %d\n", (int)strlen(testbuf));
|
|
|
|
for(o = curl_easy_option_next(NULL);
|
|
o;
|
|
o = curl_easy_option_next(o)) {
|
|
if(o->type == CURLOT_STRING) {
|
|
CURLcode result;
|
|
/*
|
|
* Whitelist string options that are safe for abuse
|
|
*/
|
|
CURL_IGNORE_DEPRECATION(
|
|
switch(o->id) {
|
|
case CURLOPT_PROXY_TLSAUTH_TYPE:
|
|
case CURLOPT_TLSAUTH_TYPE:
|
|
case CURLOPT_RANDOM_FILE:
|
|
case CURLOPT_EGDSOCKET:
|
|
continue;
|
|
default:
|
|
/* check this */
|
|
break;
|
|
}
|
|
)
|
|
|
|
/* This is a string. Make sure that passing in a string longer
|
|
CURL_MAX_INPUT_LENGTH returns an error */
|
|
result = curl_easy_setopt(easy, o->id, testbuf);
|
|
switch(result) {
|
|
case CURLE_BAD_FUNCTION_ARGUMENT: /* the most normal */
|
|
case CURLE_UNKNOWN_OPTION: /* left out from the build */
|
|
case CURLE_NOT_BUILT_IN: /* not supported */
|
|
case CURLE_UNSUPPORTED_PROTOCOL: /* detected by protocol2num() */
|
|
break;
|
|
default:
|
|
/* all other return codes are unexpected */
|
|
fprintf(stderr, "curl_easy_setopt(%s...) returned %d\n",
|
|
o->name, result);
|
|
error++;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
curl_easy_cleanup(easy);
|
|
curl_global_cleanup();
|
|
return error == 0 ? CURLE_OK : TEST_ERR_FAILURE;
|
|
}
|