mirror of
https://github.com/curl/curl.git
synced 2026-04-15 01:05:56 +08:00
9465327084
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to72abf7c13a#13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up tofabfa8e402#15825 Closes #16756
109 lines
3.0 KiB
C
109 lines
3.0 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "test.h"
|
|
|
|
#include "memdebug.h"
|
|
|
|
/* Test inspired by github issue 3340 */
|
|
|
|
static size_t writecb(char *buffer, size_t size, size_t nitems,
|
|
void *outstream)
|
|
{
|
|
(void)buffer;
|
|
(void)size;
|
|
(void)nitems;
|
|
(void)outstream;
|
|
return 0;
|
|
}
|
|
|
|
CURLcode test(char *URL)
|
|
{
|
|
CURL *curl;
|
|
CURLcode res = CURLE_OK;
|
|
long curlResponseCode;
|
|
long curlRedirectCount;
|
|
char *effectiveUrl = NULL;
|
|
char *redirectUrl = NULL;
|
|
#ifdef LIB1543
|
|
CURLU *urlu = NULL;
|
|
#endif
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
fprintf(stderr, "curl_easy_init() failed\n");
|
|
curl_global_cleanup();
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
#ifdef LIB1543
|
|
/* set CURLOPT_URLU */
|
|
{
|
|
CURLUcode rc = CURLUE_OK;
|
|
urlu = curl_url();
|
|
if(urlu)
|
|
rc = curl_url_set(urlu, CURLUPART_URL, URL, CURLU_ALLOW_SPACE);
|
|
if(!urlu || rc) {
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_CURLU, urlu);
|
|
}
|
|
test_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
|
|
#else
|
|
test_setopt(curl, CURLOPT_URL, URL);
|
|
/* just to make it explicit and visible in this test: */
|
|
test_setopt(curl, CURLOPT_FOLLOWLOCATION, 0L);
|
|
#endif
|
|
|
|
|
|
/* Perform the request, res will get the return code */
|
|
res = curl_easy_perform(curl);
|
|
if(res)
|
|
goto test_cleanup;
|
|
|
|
curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &curlResponseCode);
|
|
curl_easy_getinfo(curl, CURLINFO_REDIRECT_COUNT, &curlRedirectCount);
|
|
curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &effectiveUrl);
|
|
curl_easy_getinfo(curl, CURLINFO_REDIRECT_URL, &redirectUrl);
|
|
test_setopt(curl, CURLOPT_WRITEFUNCTION, writecb);
|
|
|
|
printf("res %d\n"
|
|
"status %ld\n"
|
|
"redirects %ld\n"
|
|
"effectiveurl %s\n"
|
|
"redirecturl %s\n",
|
|
res,
|
|
curlResponseCode,
|
|
curlRedirectCount,
|
|
effectiveUrl,
|
|
redirectUrl ? redirectUrl : "blank");
|
|
|
|
test_cleanup:
|
|
|
|
/* always cleanup */
|
|
curl_easy_cleanup(curl);
|
|
curl_global_cleanup();
|
|
#ifdef LIB1543
|
|
curl_url_cleanup(urlu);
|
|
#endif
|
|
return res;
|
|
}
|