mirror of
https://github.com/curl/curl.git
synced 2026-04-13 00:31:41 +08:00
`-Weverything` is not enabled by curl, and not recommended by LLVM, because it may enable experimental options, and will result in new fallouts after toolchain upgrades. This patch aims to fix/silence as much as possible as found with llvm/clang 21.1.0. It also permanently enables warnings that were fixed in source and deemed manageable in the future. `-Wformat` warnings are addressed separately via #18343. Fix/silence warnings in the source: - typecheck-gcc.h: fix `-Wreserved-identifier`. - lib: silence `-Wcast-function-type-strict`. For llvm 16+ or Apple clang 16+. - asyn-ares: limit `HAPPY_EYEBALLS_DNS_TIMEOUT` to old c-ares versions. - curl_trc: fix `-Wc++-hidden-decl`. - doh: fix `-Wc++-keyword`. - ftp: fix `-Wreserved-identifier`. - ldap: fix `-Wreserved-identifier`. - mqtt: comment unused macro to avoid warning. - multi_ev: drop unused macros to avoid warnings. - setopt: fix useless `break;` after `return;`. - gtls, mbedtls, rustls: silence `-Wconditional-uninitialized`. - socks_sspi, schannel, x509asn1: fix `-Wimplicit-int-enum-cast`. - x509asn1: fix `-Wc++-keyword`. - openssl: scope `OSSL_UI_METHOD_CAST` to avoid unused macro warning. - libssh2, wolfssl: drop unused macros. - curl_ngtcp2, curl_quiche, httpsrr, urlapi: drop/limit unused macros. - tool_getparam: fix useless `break;` after `return;` or `break;`. Not normally enabled because it doesn't work with unity. https://github.com/llvm/llvm-project/issues/71046 - tool_operate: fix `-Wc++-keyword`. - curlinfo: fix a `-Wunsafe-buffer-usage`. - tests: silence `-Wformat-non-iso`. - lib557: fix `-Wreserved-identifier`. - lib1565: silence `-Wconditional-uninitialized`. Enable the above clang warnings permanently in picky mode: - `-Wc++-hidden-decl` - `-Wc++-keyword` (except for Windows, where it collides with `wchar_t`) - `-Wcast-function-type-strict` - `-Wcast-function-type` - `-Wconditional-uninitialized` - `-Wformat-non-iso` (except for clang-cl) - `-Wreserved-identifier` - `-Wtentative-definition-compat` Silence problematic `-Weverything` warnings globally (in picky mode): - `-Wused-but-marked-unused` (88000+ hits) and `-Wdisabled-macro-expansion` (2600+ hits). Triggered by `typecheck-gcc.h` when building with clang 14+. Maybe there exists a way to fix within that header? Ref: https://discourse.llvm.org/t/removing-wused-but-marked-unused/55310 - `-Wunsafe-buffer-usage`. clang 16+. 7000+ hits. May be useful in theory, but such high volume of hits makes it impractical to review and possibly address. Meant for C++. Ref: https://clang.llvm.org/docs/SafeBuffers.html Ref: https://stackoverflow.com/questions/77017567/how-to-fix-code-to-avoid-warning-wunsafe-buffer-usage Ref: https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734 Ref: https://github.com/llvm/llvm-project/pull/111624 - `-Wimplicit-void-ptr-cast`. clang 21+. 1700+ hits. C++ warning, deemed pure noise. Ref: https://github.com/curl/curl/issues/18470#issuecomment-3253506266 - `-Wswitch-default` (180+ hits), `-Wswitch-enum` (190+ hits), `-Wcovered-switch-default` (20+ hits). Next to impossible to fix cleanly, esp. when the covered `case` branches depend on compile-time options. - `-Wdocumentation-unknown-command` (8+ hits). Triggered in a few sources. Seems arbitrary and bogus. - `-Wpadded` (550+ hits). - `-Wc++-keyword` on Windows, where it collides with `wchar_t`. (100+ hits) Ref: https://github.com/llvm/llvm-project/issues/155988 - `-Wreserved-macro-identifier`. clang 13+. 5+ hits. Sometimes it's necessary to set external macros that use the reserved namespace. E.g. `_CRT_NONSTDC_NO_DEPRECATE`, `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__`, `__NO_NET_API`, possibly `_REENTRANT`, and more. It's not worth trying to silence them individually. - `-Wnonportable-system-include-path` with `clang-cl`. It'd be broken by doing what the warning suggests. - `-Wformat-non-iso` for clang-cl. CMake `PICKY_COMPILER=ON` (the default) or `./configure` `--enable-warnings` (not the default) is required to enable these silencing rules. Also: - autotools, cmake: fix Apple clang and mainline llvm version translations. Ref: https://en.wikipedia.org/wiki/Xcode#Toolchain_versions - autotools, cmake: enable `-Warray-compare` for clang 20+. Follow-up to4b7accda5a#17196 - cmake: fix to enable `-Wmissing-variable-declarations` at an earlier clang version. - cmake: update internal logic to handle warning options with `+` in them. - cmake: fix internal logic to match the whole option when looking into `CMAKE_C_FLAGS` for custom-disabled warnings. Follow-up tob85cb8cb4e#18485 Closes #18477
208 lines
4.9 KiB
C
208 lines
4.9 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "first.h"
|
|
|
|
#include "memdebug.h"
|
|
|
|
#ifdef HAVE_PTHREAD_H
|
|
#include <pthread.h>
|
|
|
|
#define CONN_NUM 3
|
|
#define TIME_BETWEEN_START_SECS 2
|
|
|
|
static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
|
|
static CURL *pending_handles[CONN_NUM];
|
|
static int pending_num = 0;
|
|
static CURLcode t1565_test_failure = CURLE_OK;
|
|
|
|
static CURLM *testmulti = NULL;
|
|
static const char *t1565_url;
|
|
|
|
static void *t1565_run_thread(void *ptr)
|
|
{
|
|
CURL *easy = NULL;
|
|
CURLcode res = CURLE_OK;
|
|
int i;
|
|
|
|
(void)ptr;
|
|
|
|
for(i = 0; i < CONN_NUM; i++) {
|
|
curlx_wait_ms(TIME_BETWEEN_START_SECS * 1000);
|
|
|
|
easy_init(easy);
|
|
|
|
easy_setopt(easy, CURLOPT_URL, t1565_url);
|
|
easy_setopt(easy, CURLOPT_VERBOSE, 0L);
|
|
|
|
pthread_mutex_lock(&lock);
|
|
|
|
if(t1565_test_failure) {
|
|
pthread_mutex_unlock(&lock);
|
|
goto test_cleanup;
|
|
}
|
|
|
|
pending_handles[pending_num] = easy;
|
|
pending_num++;
|
|
easy = NULL;
|
|
|
|
pthread_mutex_unlock(&lock);
|
|
|
|
res_multi_wakeup(testmulti);
|
|
}
|
|
|
|
test_cleanup:
|
|
|
|
curl_easy_cleanup(easy);
|
|
|
|
pthread_mutex_lock(&lock);
|
|
|
|
if(!t1565_test_failure)
|
|
t1565_test_failure = res;
|
|
|
|
pthread_mutex_unlock(&lock);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static CURLcode test_lib1565(const char *URL)
|
|
{
|
|
int still_running;
|
|
int num;
|
|
int i;
|
|
int result;
|
|
CURLcode res = CURLE_OK;
|
|
CURL *started_handles[CONN_NUM];
|
|
int started_num = 0;
|
|
int finished_num = 0;
|
|
pthread_t tid = 0;
|
|
bool tid_valid = false;
|
|
struct CURLMsg *message;
|
|
|
|
start_test_timing();
|
|
|
|
global_init(CURL_GLOBAL_ALL);
|
|
|
|
multi_init(testmulti);
|
|
|
|
t1565_url = URL;
|
|
|
|
result = pthread_create(&tid, NULL, t1565_run_thread, NULL);
|
|
if(!result)
|
|
tid_valid = true;
|
|
else {
|
|
curl_mfprintf(stderr, "%s:%d Couldn't create thread, errno %d\n",
|
|
__FILE__, __LINE__, result);
|
|
goto test_cleanup;
|
|
}
|
|
|
|
while(1) {
|
|
multi_perform(testmulti, &still_running);
|
|
|
|
abort_on_test_timeout();
|
|
|
|
while((message = curl_multi_info_read(testmulti, &num))) {
|
|
if(message->msg == CURLMSG_DONE) {
|
|
res = message->data.result;
|
|
if(res)
|
|
goto test_cleanup;
|
|
multi_remove_handle(testmulti, message->easy_handle);
|
|
finished_num++;
|
|
}
|
|
else {
|
|
curl_mfprintf(stderr,
|
|
"%s:%d Got an unexpected message from curl: %i\n",
|
|
__FILE__, __LINE__, message->msg);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
|
|
abort_on_test_timeout();
|
|
}
|
|
|
|
if(CONN_NUM == finished_num)
|
|
break;
|
|
|
|
multi_poll(testmulti, NULL, 0, TEST_HANG_TIMEOUT, &num);
|
|
|
|
abort_on_test_timeout();
|
|
|
|
pthread_mutex_lock(&lock);
|
|
|
|
while(pending_num > 0) {
|
|
res_multi_add_handle(testmulti, pending_handles[pending_num - 1]);
|
|
if(res) {
|
|
pthread_mutex_unlock(&lock);
|
|
goto test_cleanup;
|
|
}
|
|
|
|
started_handles[started_num] = pending_handles[pending_num - 1];
|
|
started_num++;
|
|
pending_num--;
|
|
}
|
|
|
|
pthread_mutex_unlock(&lock);
|
|
|
|
abort_on_test_timeout();
|
|
}
|
|
|
|
if(CONN_NUM != started_num) {
|
|
curl_mfprintf(stderr, "%s:%d Not all connections started: %d of %d\n",
|
|
__FILE__, __LINE__, started_num, CONN_NUM);
|
|
goto test_cleanup;
|
|
}
|
|
|
|
if(CONN_NUM != finished_num) {
|
|
curl_mfprintf(stderr, "%s:%d Not all connections finished: %d of %d\n",
|
|
__FILE__, __LINE__, started_num, CONN_NUM);
|
|
goto test_cleanup;
|
|
}
|
|
|
|
test_cleanup:
|
|
|
|
pthread_mutex_lock(&lock);
|
|
if(!t1565_test_failure)
|
|
t1565_test_failure = res;
|
|
pthread_mutex_unlock(&lock);
|
|
|
|
if(tid_valid)
|
|
pthread_join(tid, NULL);
|
|
|
|
curl_multi_cleanup(testmulti);
|
|
for(i = 0; i < pending_num; i++)
|
|
curl_easy_cleanup(pending_handles[i]);
|
|
for(i = 0; i < started_num; i++)
|
|
curl_easy_cleanup(started_handles[i]);
|
|
curl_global_cleanup();
|
|
|
|
return t1565_test_failure;
|
|
}
|
|
|
|
#else /* without pthread, this test doesn't work */
|
|
static CURLcode test_lib1565(const char *URL)
|
|
{
|
|
(void)URL;
|
|
return CURLE_OK;
|
|
}
|
|
#endif
|