mirror of
https://github.com/curl/curl.git
synced 2026-04-14 00:51:42 +08:00
Before this patch curl used the C preprocessor to override standard memory allocation symbols: malloc, calloc, strdup, realloc, free. The goal of these is to replace them with curl's debug wrappers in `CURLDEBUG` builds, another was to replace them with the wrappers calling user-defined allocators in libcurl. This solution needed a bunch of workarounds to avoid breaking external headers: it relied on include order to do the overriding last. For "unity" builds it needed to reset overrides before external includes. Also in test apps, which are always built as single source files. It also needed the `(symbol)` trick to avoid overrides in some places. This would still not fix cases where the standard symbols were macros. It was also fragile and difficult to figure out which was the actual function behind an alloc or free call in a specific piece of code. This in turn caused bugs where the wrong allocator was accidentally called. To avoid these problems, this patch replaces this solution with `curlx_`-prefixed allocator macros, and mapping them _once_ to either the libcurl wrappers, the debug wrappers or the standard ones, matching the rest of the code in libtests. This concludes the long journey to avoid redefining standard functions in the curl codebase. Note: I did not update `packages/OS400/*.c` sources. They did not `#include` `curl_setup.h`, `curl_memory.h` or `memdebug.h`, meaning the overrides were never applied to them. This may or may not have been correct. For now I suppressed the direct use of standard allocators via a local `.checksrc`. Probably they (except for `curlcl.c`) should be updated to include `curl_setup.h` and use the `curlx_` macros. This patch changes mappings in two places: - `lib/curl_threads.c` in libtests: Before this patch it mapped to libcurl allocators. After, it maps to standard allocators, like the rest of libtests code. - `units`: before this patch it mapped to standard allocators. After, it maps to libcurl allocators. Also: - drop all position-dependent `curl_memory.h` and `memdebug.h` includes, and delete the now unnecessary headers. - rename `Curl_tcsdup` macro to `curlx_tcsdup` and define like the other allocators. - map `curlx_strdup()` to `_strdup()` on Windows (was: `strdup()`). To fix warnings silenced via `_CRT_NONSTDC_NO_DEPRECATE`. - multibyte: map `curlx_convert_*()` to `_strdup()` on Windows (was: `strdup()`). - src: do not reuse the `strdup` name for the local replacement. - lib509: call `_strdup()` on Windows (was: `strdup()`). - test1132: delete test obsoleted by this patch. - CHECKSRC.md: update text for `SNPRINTF`. - checksrc: ban standard allocator symbols. Follow-up tob12da22db1#18866 Follow-up todb98daab05#18844 Follow-up to4deea9396b#18814 Follow-up to9678ff5b1b#18776 Follow-up to10bac43b87#18774 Follow-up to20142f5d06#18634 Follow-up tobf7375ecc5#18503 Follow-up to9863599d69#18502 Follow-up to3bb5e58c10#17827 Closes #19626
193 lines
5.3 KiB
C
193 lines
5.3 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "first.h"
|
|
|
|
#include "testtrace.h"
|
|
|
|
static FILE *out_download = NULL;
|
|
|
|
static int setup_h2_serverpush(CURL *curl, const char *url)
|
|
{
|
|
out_download = curlx_fopen("download_0.data", "wb");
|
|
if(!out_download)
|
|
return 1; /* failed */
|
|
|
|
curl_easy_setopt(curl, CURLOPT_URL, url);
|
|
curl_easy_setopt(curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0);
|
|
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
|
|
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
|
|
|
|
curl_easy_setopt(curl, CURLOPT_WRITEDATA, out_download);
|
|
|
|
/* please be verbose */
|
|
curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
curl_easy_setopt(curl, CURLOPT_DEBUGFUNCTION, libtest_debug_cb);
|
|
curl_easy_setopt(curl, CURLOPT_DEBUGDATA, &debug_config);
|
|
|
|
/* wait for pipe connection to confirm */
|
|
curl_easy_setopt(curl, CURLOPT_PIPEWAIT, 1L);
|
|
|
|
return 0; /* all is good */
|
|
}
|
|
|
|
static FILE *out_push = NULL;
|
|
|
|
/* called when there is an incoming push */
|
|
static int server_push_callback(CURL *parent,
|
|
CURL *curl,
|
|
size_t num_headers,
|
|
struct curl_pushheaders *headers,
|
|
void *userp)
|
|
{
|
|
char *headp;
|
|
size_t i;
|
|
int *transfers = (int *)userp;
|
|
char filename[128];
|
|
static unsigned int count = 0;
|
|
|
|
(void)parent;
|
|
|
|
curl_msnprintf(filename, sizeof(filename) - 1, "push%u", count++);
|
|
|
|
/* here's a new stream, save it in a new file for each new push */
|
|
out_push = curlx_fopen(filename, "wb");
|
|
if(!out_push) {
|
|
/* if we cannot save it, deny it */
|
|
curl_mfprintf(stderr, "Failed to create output file for push\n");
|
|
return CURL_PUSH_DENY;
|
|
}
|
|
|
|
/* write to this file */
|
|
curl_easy_setopt(curl, CURLOPT_WRITEDATA, out_push);
|
|
|
|
curl_mfprintf(stderr, "**** push callback approves stream %u, "
|
|
"got %zu headers!\n", count, num_headers);
|
|
|
|
for(i = 0; i < num_headers; i++) {
|
|
headp = curl_pushheader_bynum(headers, i);
|
|
curl_mfprintf(stderr, "**** header %zu: %s\n", i, headp);
|
|
}
|
|
|
|
headp = curl_pushheader_byname(headers, ":path");
|
|
if(headp) {
|
|
curl_mfprintf(stderr, "**** The PATH is %s\n",
|
|
headp /* skip :path + colon */);
|
|
}
|
|
|
|
(*transfers)++; /* one more */
|
|
|
|
return CURL_PUSH_OK;
|
|
}
|
|
|
|
/*
|
|
* Download a file over HTTP/2, take care of server push.
|
|
*/
|
|
static CURLcode test_cli_h2_serverpush(const char *URL)
|
|
{
|
|
CURL *curl = NULL;
|
|
CURLM *multi;
|
|
int transfers = 1; /* we start with one */
|
|
CURLcode res = CURLE_OK;
|
|
|
|
debug_config.nohex = TRUE;
|
|
debug_config.tracetime = FALSE;
|
|
|
|
if(!URL) {
|
|
curl_mfprintf(stderr, "need URL as argument\n");
|
|
return (CURLcode)2;
|
|
}
|
|
|
|
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
|
curl_mfprintf(stderr, "curl_global_init() failed\n");
|
|
return (CURLcode)3;
|
|
}
|
|
|
|
multi = curl_multi_init();
|
|
if(!multi) {
|
|
res = (CURLcode)1;
|
|
goto cleanup;
|
|
}
|
|
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
res = (CURLcode)1;
|
|
goto cleanup;
|
|
}
|
|
|
|
if(setup_h2_serverpush(curl, URL)) {
|
|
curl_mfprintf(stderr, "failed\n");
|
|
res = (CURLcode)1;
|
|
goto cleanup;
|
|
}
|
|
|
|
curl_multi_setopt(multi, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX);
|
|
curl_multi_setopt(multi, CURLMOPT_PUSHFUNCTION, server_push_callback);
|
|
curl_multi_setopt(multi, CURLMOPT_PUSHDATA, &transfers);
|
|
|
|
curl_multi_add_handle(multi, curl);
|
|
|
|
do {
|
|
struct CURLMsg *m;
|
|
int still_running; /* keep number of running handles */
|
|
CURLMcode mc = curl_multi_perform(multi, &still_running);
|
|
|
|
if(still_running)
|
|
/* wait for activity, timeout or "nothing" */
|
|
mc = curl_multi_poll(multi, NULL, 0, 1000, NULL);
|
|
|
|
if(mc)
|
|
break;
|
|
|
|
/*
|
|
* A little caution when doing server push is that libcurl itself has
|
|
* created and added one or more easy handles but we need to clean them up
|
|
* when we are done.
|
|
*/
|
|
do {
|
|
int msgq = 0;
|
|
m = curl_multi_info_read(multi, &msgq);
|
|
if(m && (m->msg == CURLMSG_DONE)) {
|
|
CURL *easy = m->easy_handle;
|
|
transfers--;
|
|
curl_multi_remove_handle(multi, easy);
|
|
curl_easy_cleanup(easy);
|
|
}
|
|
} while(m);
|
|
|
|
} while(transfers); /* as long as we have transfers going */
|
|
|
|
cleanup:
|
|
|
|
curl_multi_cleanup(multi);
|
|
|
|
if(out_download)
|
|
curlx_fclose(out_download);
|
|
if(out_push)
|
|
curlx_fclose(out_push);
|
|
|
|
curl_global_cleanup();
|
|
|
|
return res;
|
|
}
|