mirror of
https://github.com/curl/curl.git
synced 2026-04-15 01:05:56 +08:00
9465327084
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to72abf7c13a#13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up tofabfa8e402#15825 Closes #16756
135 lines
4.4 KiB
C
135 lines
4.4 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curlcheck.h"
|
|
|
|
#include "urldata.h"
|
|
#include "url.h"
|
|
|
|
#include "memdebug.h" /* LAST include file */
|
|
|
|
static CURLcode unit_setup(void)
|
|
{
|
|
CURLcode res = CURLE_OK;
|
|
global_init(CURL_GLOBAL_ALL);
|
|
return res;
|
|
}
|
|
|
|
static void unit_stop(void)
|
|
{
|
|
curl_global_cleanup();
|
|
}
|
|
|
|
static void test_parse(
|
|
const char *input,
|
|
const char *exp_username,
|
|
const char *exp_password,
|
|
const char *exp_options)
|
|
{
|
|
char *userstr = NULL;
|
|
char *passwdstr = NULL;
|
|
char *options = NULL;
|
|
CURLcode rc = Curl_parse_login_details(input, strlen(input),
|
|
&userstr, &passwdstr, &options);
|
|
fail_unless(rc == CURLE_OK, "Curl_parse_login_details() failed");
|
|
|
|
fail_unless(!!exp_username == !!userstr, "username expectation failed");
|
|
fail_unless(!!exp_password == !!passwdstr, "password expectation failed");
|
|
fail_unless(!!exp_options == !!options, "options expectation failed");
|
|
|
|
if(!unitfail) {
|
|
fail_unless(!userstr || !exp_username ||
|
|
strcmp(userstr, exp_username) == 0,
|
|
"userstr should be equal to exp_username");
|
|
fail_unless(!passwdstr || !exp_password ||
|
|
strcmp(passwdstr, exp_password) == 0,
|
|
"passwdstr should be equal to exp_password");
|
|
fail_unless(!options || !exp_options ||
|
|
strcmp(options, exp_options) == 0,
|
|
"options should be equal to exp_options");
|
|
}
|
|
|
|
free(userstr);
|
|
free(passwdstr);
|
|
free(options);
|
|
}
|
|
|
|
UNITTEST_START
|
|
{
|
|
CURLcode rc;
|
|
struct Curl_easy *empty;
|
|
enum dupstring i;
|
|
|
|
bool async = FALSE;
|
|
bool protocol_connect = FALSE;
|
|
|
|
rc = Curl_open(&empty);
|
|
if(rc)
|
|
goto unit_test_abort;
|
|
fail_unless(rc == CURLE_OK, "Curl_open() failed");
|
|
|
|
rc = Curl_connect(empty, &async, &protocol_connect);
|
|
fail_unless(rc == CURLE_URL_MALFORMAT,
|
|
"Curl_connect() failed to return CURLE_URL_MALFORMAT");
|
|
|
|
fail_unless(empty->magic == CURLEASY_MAGIC_NUMBER,
|
|
"empty->magic should be equal to CURLEASY_MAGIC_NUMBER");
|
|
|
|
/* double invoke to ensure no dependency on internal state */
|
|
rc = Curl_connect(empty, &async, &protocol_connect);
|
|
fail_unless(rc == CURLE_URL_MALFORMAT,
|
|
"Curl_connect() failed to return CURLE_URL_MALFORMAT");
|
|
|
|
rc = Curl_init_userdefined(empty);
|
|
fail_unless(rc == CURLE_OK, "Curl_userdefined() failed");
|
|
|
|
rc = Curl_init_do(empty, empty->conn);
|
|
fail_unless(rc == CURLE_OK, "Curl_init_do() failed");
|
|
|
|
test_parse("hostname", "hostname", NULL, NULL);
|
|
test_parse("user:password", "user", "password", NULL);
|
|
test_parse("user:password;options", "user", "password", "options");
|
|
test_parse("user:password;options;more", "user", "password", "options;more");
|
|
test_parse("", "", NULL, NULL);
|
|
test_parse(":", "", "", NULL);
|
|
test_parse(":;", "", "", NULL);
|
|
test_parse(":password", "", "password", NULL);
|
|
test_parse(":password;", "", "password", NULL);
|
|
test_parse(";options", "", NULL, "options");
|
|
test_parse("user;options", "user", NULL, "options");
|
|
test_parse("user:;options", "user", "", "options");
|
|
test_parse("user;options:password", "user", "password", "options");
|
|
test_parse("user;options:", "user", "", "options");
|
|
|
|
Curl_freeset(empty);
|
|
for(i = (enum dupstring)0; i < STRING_LAST; i++) {
|
|
fail_unless(empty->set.str[i] == NULL,
|
|
"Curl_free() did not set to NULL");
|
|
}
|
|
|
|
rc = Curl_close(&empty);
|
|
fail_unless(rc == CURLE_OK, "Curl_close() failed");
|
|
|
|
}
|
|
UNITTEST_STOP
|