mirror of
https://github.com/curl/curl.git
synced 2026-04-15 01:05:56 +08:00
f4e23950c7
The issues found fell into these categories, with the applied fixes:
- const was accidentally stripped.
Adjust code to not cast or cast with const.
- const/volatile missing from arguments, local variables.
Constify arguments or variables, adjust/delete casts. Small code
changes in a few places.
- const must be stripped because an API dependency requires it.
Strip `const` with `CURL_UNCONST()` macro to silence the warning out
of our control. These happen at API boundaries. Sometimes they depend
on dependency version, which this patch handles as necessary. Also
enable const support for the zlib API, using `ZLIB_CONST`. Supported
by zlib 1.2.5.2 and newer.
- const must be stripped because a curl API requires it.
Strip `const` with `CURL_UNCONST()` macro to silence the warning out
of our immediate control. For example we promise to send a non-const
argument to a callback, though the data is const internally.
- other cases where we may avoid const stripping by code changes.
Also silenced with `CURL_UNCONST()`.
- there are 3 places where `CURL_UNCONST()` is cast again to const.
To silence this type of warning:
```
lib/vquic/curl_osslq.c:1015:29: error: to be safe all intermediate
pointers in cast from 'unsigned char **' to 'const unsigned char **'
must be 'const' qualified [-Werror=cast-qual]
lib/cf-socket.c:734:32: error: to be safe all intermediate pointers in
cast from 'char **' to 'const char **' must be 'const' qualified
[-Werror=cast-qual]
```
There may be a better solution, but I couldn't find it.
These cases are handled in separate subcommits, but without further
markup.
If you see a `-Wcast-qual` warning in curl, we appreciate your report
about it.
Closes #16142
195 lines
6.1 KiB
C
195 lines
6.1 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curlcheck.h"
|
|
#include "netrc.h"
|
|
#include "memdebug.h" /* LAST include file */
|
|
|
|
#ifndef CURL_DISABLE_NETRC
|
|
|
|
static char *s_login;
|
|
static char *s_password;
|
|
|
|
static CURLcode unit_setup(void)
|
|
{
|
|
s_password = NULL;
|
|
s_login = NULL;
|
|
return CURLE_OK;
|
|
}
|
|
|
|
static void unit_stop(void)
|
|
{
|
|
Curl_safefree(s_password);
|
|
Curl_safefree(s_login);
|
|
}
|
|
|
|
UNITTEST_START
|
|
{
|
|
int result;
|
|
struct store_netrc store;
|
|
|
|
/*
|
|
* Test a non existent host in our netrc file.
|
|
*/
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"test.example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 1, "Host not found should return 1");
|
|
abort_unless(s_password == NULL, "password did not return NULL!");
|
|
abort_unless(s_login == NULL, "user did not return NULL!");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test a non existent login in our netrc file.
|
|
*/
|
|
s_login = (char *)CURL_UNCONST("me");
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 0, "Host should have been found");
|
|
abort_unless(s_password == NULL, "password is not NULL!");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test a non existent login and host in our netrc file.
|
|
*/
|
|
s_login = (char *)CURL_UNCONST("me");
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"test.example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 1, "Host not found should return 1");
|
|
abort_unless(s_password == NULL, "password is not NULL!");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test a non existent login (substring of an existing one) in our
|
|
* netrc file.
|
|
*/
|
|
s_login = (char *)CURL_UNCONST("admi");
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 0, "Host should have been found");
|
|
abort_unless(s_password == NULL, "password is not NULL!");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test a non existent login (superstring of an existing one)
|
|
* in our netrc file.
|
|
*/
|
|
s_login = (char *)CURL_UNCONST("adminn");
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 0, "Host should have been found");
|
|
abort_unless(s_password == NULL, "password is not NULL!");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test for the first existing host in our netrc file
|
|
* with s_login[0] = 0.
|
|
*/
|
|
s_login = NULL;
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 0, "Host should have been found");
|
|
abort_unless(s_password != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_password, "passwd", 6) == 0,
|
|
"password should be 'passwd'");
|
|
abort_unless(s_login != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_login, "admin", 5) == 0, "login should be 'admin'");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test for the first existing host in our netrc file
|
|
* with s_login[0] != 0.
|
|
*/
|
|
free(s_password);
|
|
free(s_login);
|
|
s_password = NULL;
|
|
s_login = NULL;
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 0, "Host should have been found");
|
|
abort_unless(s_password != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_password, "passwd", 6) == 0,
|
|
"password should be 'passwd'");
|
|
abort_unless(s_login != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_login, "admin", 5) == 0, "login should be 'admin'");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test for the second existing host in our netrc file
|
|
* with s_login[0] = 0.
|
|
*/
|
|
free(s_password);
|
|
s_password = NULL;
|
|
free(s_login);
|
|
s_login = NULL;
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"curl.example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 0, "Host should have been found");
|
|
abort_unless(s_password != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_password, "none", 4) == 0,
|
|
"password should be 'none'");
|
|
abort_unless(s_login != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_login, "none", 4) == 0, "login should be 'none'");
|
|
Curl_netrc_cleanup(&store);
|
|
|
|
/*
|
|
* Test for the second existing host in our netrc file
|
|
* with s_login[0] != 0.
|
|
*/
|
|
free(s_password);
|
|
free(s_login);
|
|
s_password = NULL;
|
|
s_login = NULL;
|
|
Curl_netrc_init(&store);
|
|
result = Curl_parsenetrc(&store,
|
|
"curl.example.com", &s_login, &s_password, arg);
|
|
fail_unless(result == 0, "Host should have been found");
|
|
abort_unless(s_password != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_password, "none", 4) == 0,
|
|
"password should be 'none'");
|
|
abort_unless(s_login != NULL, "returned NULL!");
|
|
fail_unless(strncmp(s_login, "none", 4) == 0, "login should be 'none'");
|
|
Curl_netrc_cleanup(&store);
|
|
}
|
|
UNITTEST_STOP
|
|
|
|
#else
|
|
static CURLcode unit_setup(void)
|
|
{
|
|
return CURLE_OK;
|
|
}
|
|
static void unit_stop(void)
|
|
{
|
|
}
|
|
UNITTEST_START
|
|
UNITTEST_STOP
|
|
|
|
#endif
|