curl-curl/tests/unit
Viktor Szakats f4e23950c7
build: enable -Wcast-qual, fix or silence compiler warnings
The issues found fell into these categories, with the applied fixes:

- const was accidentally stripped.
  Adjust code to not cast or cast with const.

- const/volatile missing from arguments, local variables.
  Constify arguments or variables, adjust/delete casts. Small code
  changes in a few places.

- const must be stripped because an API dependency requires it.
  Strip `const` with `CURL_UNCONST()` macro to silence the warning out
  of our control. These happen at API boundaries. Sometimes they depend
  on dependency version, which this patch handles as necessary. Also
  enable const support for the zlib API, using `ZLIB_CONST`. Supported
  by zlib 1.2.5.2 and newer.

- const must be stripped because a curl API requires it.
  Strip `const` with `CURL_UNCONST()` macro to silence the warning out
  of our immediate control. For example we promise to send a non-const
  argument to a callback, though the data is const internally.

- other cases where we may avoid const stripping by code changes.
  Also silenced with `CURL_UNCONST()`.

- there are 3 places where `CURL_UNCONST()` is cast again to const.
  To silence this type of warning:
  ```
  lib/vquic/curl_osslq.c:1015:29: error: to be safe all intermediate
    pointers in cast from 'unsigned char **' to 'const unsigned char **'
    must be 'const' qualified [-Werror=cast-qual]
  lib/cf-socket.c:734:32: error: to be safe all intermediate pointers in
    cast from 'char **' to 'const char **' must be 'const' qualified
    [-Werror=cast-qual]
  ```
  There may be a better solution, but I couldn't find it.

These cases are handled in separate subcommits, but without further
markup.

If you see a `-Wcast-qual` warning in curl, we appreciate your report
about it.

Closes #16142
2025-03-10 22:30:15 +01:00
..
.gitignore tidy-up: .gitignore lines mostly 2025-01-27 20:59:46 +01:00
CMakeLists.txt cmake: namespace functions and macros 2024-12-16 21:55:00 +01:00
curlcheck.h Makefile.mk: drop in favour of autotools and cmake (MS-DOS, AmigaOS3) 2024-12-16 23:20:55 +01:00
Makefile.am checksrc: exclude generated bundle files to avoid race condition 2025-01-27 20:59:47 +01:00
Makefile.inc x509asn1: add parse recursion limit 2025-02-03 20:10:09 +01:00
README.md docs: use lowercase curl and libcurl 2025-01-02 17:15:54 +01:00
unit1300.c unit1300: fix checksrc longline warnings 2024-08-21 03:37:29 -04:00
unit1302.c tests: speed up builds with single-binary test bundles 2024-09-22 09:51:15 +02:00
unit1303.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1304.c build: enable -Wcast-qual, fix or silence compiler warnings 2025-03-10 22:30:15 +01:00
unit1305.c tests: speed up builds with single-binary test bundles 2024-09-22 09:51:15 +02:00
unit1307.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1308.c build: tidy up deprecation suppression, enable warnings for clang 2024-09-21 00:59:52 +02:00
unit1309.c lib/src: white space edits to comply better with code style 2024-09-19 14:59:12 +02:00
unit1323.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1330.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1394.c windows: use built-in _WIN32 macro to detect Windows 2023-11-22 15:42:25 +00:00
unit1395.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1396.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1397.c gskit: remove 2023-08-07 20:57:48 +02:00
unit1398.c build: fix compiling with GCC 4.x versions 2025-01-22 11:26:15 +01:00
unit1399.c lib/src: white space edits to comply better with code style 2024-09-19 14:59:12 +02:00
unit1600.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1601.c lib: add ability to disable auths individually 2023-09-07 17:45:06 +02:00
unit1602.c src: fix potential macro confusion in cmake unity builds 2024-08-22 10:45:04 +02:00
unit1603.c src: fix potential macro confusion in cmake unity builds 2024-08-22 10:45:04 +02:00
unit1604.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1605.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1606.c tests: speed up builds with single-binary test bundles 2024-09-22 09:51:15 +02:00
unit1607.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1608.c test1608: make it build and get skipped without shuffle DNS support 2023-08-17 17:17:59 +02:00
unit1609.c tidy-up: alphasort lists, indentation/whitespace, pp 2025-03-04 01:46:53 +01:00
unit1610.c lib: prefer CURL_SHA256_DIGEST_LENGTH over the unprefixed name 2024-08-13 10:04:06 +02:00
unit1611.c md4: only build when used 2023-05-13 09:57:35 +02:00
unit1612.c lib: remove function pointer typecasts for hmac/sha256/md5 2024-10-15 14:32:39 +02:00
unit1614.c CI: move Azure jobs to GHA, fix fallouts, sshserver, runtests tweaks 2024-09-16 10:00:17 +02:00
unit1615.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1616.c hash_offt: standalone hash for curl_off_t 2025-03-01 18:42:10 +01:00
unit1620.c tests: extend user/password parsing test1620 2024-05-25 23:48:57 +02:00
unit1621.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1650.c build: enable -Wcast-qual, fix or silence compiler warnings 2025-03-10 22:30:15 +01:00
unit1651.c build: fix some -Wsign-conversion/-Warith-conversion warnings 2023-12-19 12:45:28 +00:00
unit1652.c multi: event based rework 2025-02-22 14:47:40 +01:00
unit1653.c checksrc: disallow spaces before labels 2023-05-18 20:45:04 +02:00
unit1654.c altsvc: rewrite parser using strparse 2025-02-26 08:36:08 +01:00
unit1655.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1656.c tidy-up: make per-file ARRAYSIZE macros global as CURL_ARRAYSIZE 2025-02-07 14:21:59 +01:00
unit1657.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00
unit1660.c strparse: string parsing helper functions 2024-12-12 16:00:52 +01:00
unit1661.c build: enable -Wcast-qual, fix or silence compiler warnings 2025-03-10 22:30:15 +01:00
unit1663.c tests: speed up builds with single-binary test bundles 2024-09-22 09:51:15 +02:00
unit1664.c strparse: speed up the hex parser somewhat 2025-02-19 07:49:06 +01:00
unit2600.c build: add Windows CE / CeGCC support, with CI jobs 2025-02-21 13:56:34 +01:00
unit2601.c bufq: unwrite fix 2024-10-03 13:27:36 +02:00
unit2602.c trace: make tracing available in non-debug builds 2023-08-03 17:32:25 +02:00
unit2603.c CI: move Azure jobs to GHA, fix fallouts, sshserver, runtests tweaks 2024-09-16 10:00:17 +02:00
unit2604.c build: enable -Wcast-qual, fix or silence compiler warnings 2025-03-10 22:30:15 +01:00
unit3200.c build: fix compiling with GCC 4.x versions 2025-01-22 11:26:15 +01:00
unit3205.c tidy-up: use CURL_ARRAYSIZE() 2025-02-19 00:59:45 +01:00

Unit tests

The goal is to add tests for all functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones.

Build Unit Tests

./configure --enable-debug is required for the unit tests to build. To enable unit tests, there is a separate static libcurl built that is used exclusively for linking unit test programs. Just build everything as normal, and then you can run the unit test cases as well.

Run Unit Tests

Unit tests are run as part of the regular test suite. If you have built everything to run unit tests, to can do 'make test' at the root level. Or you can cd tests and make and then invoke individual unit tests with ./runtests.pl NNNN where NNNN is the specific test number.

Debug Unit Tests

If a specific test fails you get told. The test case then has output left in the %LOGDIR subdirectory, but most importantly you can re-run the test again using gdb by doing ./runtests.pl -g NNNN. That is, add a -g to make it start up gdb and run the same case using that.

Write Unit Tests

We put tests that focus on an area or a specific function into a single C source file. The source file should be named unitNNNN.c where NNNN is a previously unused number.

Add your test to tests/unit/Makefile.inc (if it is a unit test). Add your test data filename to tests/data/Makefile.am

You also need a separate file called tests/data/testNNNN (using the same number) that describes your test case. See the test1300 file for inspiration and the tests/FILEFORMAT.md documentation.

For the actual C file, here's a simple example:


    #include "curlcheck.h"

    #include "a libcurl header.h" /* from the lib dir */

    static CURLcode unit_setup( void )
    {
      /* whatever you want done first */
      return CURLE_OK;
    }

    static void unit_stop( void )
    {
      /* done before shutting down and exiting */
    }

    UNITTEST_START

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

    UNITTEST_STOP