curl-curl/tests/unit
Viktor Szakats 92f215fea1
build: address some -Weverything warnings, update picky warnings
`-Weverything` is not enabled by curl, and not recommended by LLVM,
because it may enable experimental options, and will result in new
fallouts after toolchain upgrades. This patch aims to fix/silence as much
as possible as found with llvm/clang 21.1.0. It also permanently enables
warnings that were fixed in source and deemed manageable in the future.
`-Wformat` warnings are addressed separately via #18343.

Fix/silence warnings in the source:
- typecheck-gcc.h: fix `-Wreserved-identifier`.
- lib: silence `-Wcast-function-type-strict`.
  For llvm 16+ or Apple clang 16+.
- asyn-ares: limit `HAPPY_EYEBALLS_DNS_TIMEOUT` to old c-ares versions.
- curl_trc: fix `-Wc++-hidden-decl`.
- doh: fix `-Wc++-keyword`.
- ftp: fix `-Wreserved-identifier`.
- ldap: fix `-Wreserved-identifier`.
- mqtt: comment unused macro to avoid warning.
- multi_ev: drop unused macros to avoid warnings.
- setopt: fix useless `break;` after `return;`.
- gtls, mbedtls, rustls: silence `-Wconditional-uninitialized`.
- socks_sspi, schannel, x509asn1: fix `-Wimplicit-int-enum-cast`.
- x509asn1: fix `-Wc++-keyword`.
- openssl: scope `OSSL_UI_METHOD_CAST` to avoid unused macro warning.
- libssh2, wolfssl: drop unused macros.
- curl_ngtcp2, curl_quiche, httpsrr, urlapi: drop/limit unused macros.
- tool_getparam: fix useless `break;` after `return;` or `break;`.
  Not normally enabled because it doesn't work with unity.
  https://github.com/llvm/llvm-project/issues/71046
- tool_operate: fix `-Wc++-keyword`.
- curlinfo: fix a `-Wunsafe-buffer-usage`.
- tests: silence `-Wformat-non-iso`.
- lib557: fix `-Wreserved-identifier`.
- lib1565: silence `-Wconditional-uninitialized`.

Enable the above clang warnings permanently in picky mode:
- `-Wc++-hidden-decl`
- `-Wc++-keyword` (except for Windows, where it collides with `wchar_t`)
- `-Wcast-function-type-strict`
- `-Wcast-function-type`
- `-Wconditional-uninitialized`
- `-Wformat-non-iso` (except for clang-cl)
- `-Wreserved-identifier`
- `-Wtentative-definition-compat`

Silence problematic `-Weverything` warnings globally (in picky mode):
- `-Wused-but-marked-unused` (88000+ hits) and
  `-Wdisabled-macro-expansion` (2600+ hits).
  Triggered by `typecheck-gcc.h` when building with clang 14+.
  Maybe there exists a way to fix within that header?
  Ref: https://discourse.llvm.org/t/removing-wused-but-marked-unused/55310
- `-Wunsafe-buffer-usage`. clang 16+. 7000+ hits.
  May be useful in theory, but such high volume of hits makes it
  impractical to review and possibly address. Meant for C++.
  Ref: https://clang.llvm.org/docs/SafeBuffers.html
  Ref: https://stackoverflow.com/questions/77017567/how-to-fix-code-to-avoid-warning-wunsafe-buffer-usage
  Ref: https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734
  Ref: https://github.com/llvm/llvm-project/pull/111624
- `-Wimplicit-void-ptr-cast`. clang 21+. 1700+ hits.
  C++ warning, deemed pure noise.
  Ref: https://github.com/curl/curl/issues/18470#issuecomment-3253506266
- `-Wswitch-default` (180+ hits), `-Wswitch-enum` (190+ hits),
  `-Wcovered-switch-default` (20+ hits).
  Next to impossible to fix cleanly, esp. when the covered `case`
  branches depend on compile-time options.
- `-Wdocumentation-unknown-command` (8+ hits).
  Triggered in a few sources. Seems arbitrary and bogus.
- `-Wpadded` (550+ hits).
- `-Wc++-keyword` on Windows, where it collides with `wchar_t`.
  (100+ hits)
  Ref: https://github.com/llvm/llvm-project/issues/155988
- `-Wreserved-macro-identifier`. clang 13+. 5+ hits.
  Sometimes it's necessary to set external macros that use
  the reserved namespace. E.g. `_CRT_NONSTDC_NO_DEPRECATE`,
  `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__`, `__NO_NET_API`,
  possibly `_REENTRANT`, and more.
  It's not worth trying to silence them individually.
- `-Wnonportable-system-include-path` with `clang-cl`.
  It'd be broken by doing what the warning suggests.
- `-Wformat-non-iso` for clang-cl.

CMake `PICKY_COMPILER=ON` (the default) or `./configure`
`--enable-warnings` (not the default) is required to enable these
silencing rules.

Also:
- autotools, cmake: fix Apple clang and mainline llvm version translations.
  Ref: https://en.wikipedia.org/wiki/Xcode#Toolchain_versions
- autotools, cmake: enable `-Warray-compare` for clang 20+.
  Follow-up to 4b7accda5a #17196
- cmake: fix to enable `-Wmissing-variable-declarations` at an earlier
  clang version.
- cmake: update internal logic to handle warning options with `+` in
  them.
- cmake: fix internal logic to match the whole option when looking
  into `CMAKE_C_FLAGS` for custom-disabled warnings.

Follow-up to b85cb8cb4e #18485

Closes #18477
2025-09-20 10:16:15 +02:00
..
.gitignore tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
CMakeLists.txt build: tidy up compiler definition for tests 2025-07-28 12:43:01 +02:00
Makefile.am unit-tests: build the unitprotos.h from here 2025-07-30 09:06:35 +02:00
Makefile.inc tests: move curlcheck.h to libtest as unitcheck.h 2025-07-09 02:29:25 +02:00
README.md tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1300.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1302.c base64: accept zero length argument to base64_encode 2025-09-19 22:57:20 +02:00
unit1303.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1304.c tidy-up: whitespace 2025-09-15 15:00:11 +02:00
unit1305.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1307.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1309.c libtests: update format strings to avoid casts, drop some macros 2025-07-31 09:29:49 +02:00
unit1323.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1330.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1395.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1396.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1397.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1398.c build: address some -Weverything warnings, update picky warnings 2025-09-20 10:16:15 +02:00
unit1399.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1600.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1601.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1602.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1603.c tidy-up: drop stray "unused" comments 2025-09-03 16:31:16 +02:00
unit1605.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1606.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1607.c hostip: do DNS cache pruning in milliseconds 2025-08-04 16:20:50 +02:00
unit1608.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1609.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1610.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1611.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1612.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1614.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1615.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1616.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1620.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1650.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1651.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1652.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1653.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1654.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1655.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1656.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1657.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1658.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1660.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1661.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1663.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1664.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1979.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1980.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit2600.c lib: replace getsock() logic with pollsets 2025-08-04 23:43:13 +02:00
unit2601.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit2602.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit2603.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit2604.c unit2604: avoid UNCONST() 2025-08-04 14:55:10 +02:00
unit3200.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit3205.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit3211.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit3212.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit3213.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit3214.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00

Unit tests

The goal is to add tests for all functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones.

Build Unit Tests

./configure --enable-debug is required for the unit tests to build. To enable unit tests, there is a separate static libcurl built that is used exclusively for linking unit test programs. Just build everything as normal, and then you can run the unit test cases as well.

Run Unit Tests

Unit tests are run as part of the regular test suite. If you have built everything to run unit tests, to can do 'make test' at the root level. Or you can cd tests and make and then invoke individual unit tests with ./runtests.pl NNNN where NNNN is the specific test number.

Debug Unit Tests

If a specific test fails you get told. The test case then has output left in the %LOGDIR subdirectory, but most importantly you can re-run the test again using gdb by doing ./runtests.pl -g NNNN. That is, add a -g to make it start up gdb and run the same case using that.

Write Unit Tests

We put tests that focus on an area or a specific function into a single C source file. The source file should be named unitNNNN.c where NNNN is a previously unused number.

Add your test to tests/unit/Makefile.inc (if it is a unit test). Add your test data filename to tests/data/Makefile.am

You also need a separate file called tests/data/testNNNN (using the same number) that describes your test case. See the test1300 file for inspiration and the tests/FILEFORMAT.md documentation.

For the actual C file, here's a simple example:

    #include "unitcheck.h"

    #include "a libcurl header.h" /* from the lib dir */

    static CURLcode test_unit9998(const char *arg)
    {
      UNITTEST_BEGIN_SIMPLE

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

      UNITTEST_END_SIMPLE
    }

Here's an example using optional initialization and cleanup:

    #include "unitcheck.h"

    #include "a libcurl header.h" /* from the lib dir */

    static CURLcode t9999_setup(void)
    {
      /* whatever you want done first */
      return CURLE_OK;
    }

    static void t9999_stop(void)
    {
      /* done before shutting down and exiting */
    }

    static CURLcode test_unit9999(const char *arg)
    {
      UNITTEST_BEGIN(t9999_setup())

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

      UNITTEST_END(t9999_stop())
    }