mirror of
https://github.com/curl/curl.git
synced 2026-04-13 00:31:41 +08:00
9465327084
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to72abf7c13a#13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up tofabfa8e402#15825 Closes #16756
98 lines
3.1 KiB
C
98 lines
3.1 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curlcheck.h"
|
|
|
|
#ifdef HAVE_NETINET_IN_H
|
|
#include <netinet/in.h>
|
|
#endif
|
|
#ifdef HAVE_NETINET_IN6_H
|
|
#include <netinet/in6.h>
|
|
#endif
|
|
|
|
#include <curl/curl.h>
|
|
|
|
#include "cf-socket.h"
|
|
|
|
#include "memdebug.h" /* LAST include file */
|
|
|
|
static CURLcode unit_setup(void)
|
|
{
|
|
CURLcode res = CURLE_OK;
|
|
global_init(CURL_GLOBAL_ALL);
|
|
return res;
|
|
}
|
|
|
|
static void unit_stop(void)
|
|
{
|
|
curl_global_cleanup();
|
|
}
|
|
|
|
static void test_parse(
|
|
const char *input_data,
|
|
const char *exp_dev,
|
|
const char *exp_iface,
|
|
const char *exp_host,
|
|
CURLcode exp_rc)
|
|
{
|
|
char *dev = NULL;
|
|
char *iface = NULL;
|
|
char *host = NULL;
|
|
CURLcode rc = Curl_parse_interface(input_data, &dev, &iface, &host);
|
|
fail_unless(rc == exp_rc, "Curl_parse_interface() failed");
|
|
|
|
fail_unless(!!exp_dev == !!dev, "dev expectation failed.");
|
|
fail_unless(!!exp_iface == !!iface, "iface expectation failed");
|
|
fail_unless(!!exp_host == !!host, "host expectation failed");
|
|
|
|
if(!unitfail) {
|
|
fail_unless(!dev || !exp_dev || strcmp(dev, exp_dev) == 0,
|
|
"dev should be equal to exp_dev");
|
|
fail_unless(!iface || !exp_iface || strcmp(iface, exp_iface) == 0,
|
|
"iface should be equal to exp_iface");
|
|
fail_unless(!host || !exp_host || strcmp(host, exp_host) == 0,
|
|
"host should be equal to exp_host");
|
|
}
|
|
|
|
free(dev);
|
|
free(iface);
|
|
free(host);
|
|
}
|
|
|
|
UNITTEST_START
|
|
{
|
|
test_parse("dev", "dev", NULL, NULL, CURLE_OK);
|
|
test_parse("if!eth0", NULL, "eth0", NULL, CURLE_OK);
|
|
test_parse("host!myname", NULL, NULL, "myname", CURLE_OK);
|
|
test_parse("ifhost!eth0!myname", NULL, "eth0", "myname", CURLE_OK);
|
|
test_parse("", NULL, NULL, NULL, CURLE_BAD_FUNCTION_ARGUMENT);
|
|
test_parse("!", "!", NULL, NULL, CURLE_OK);
|
|
test_parse("if!", NULL, NULL, NULL, CURLE_BAD_FUNCTION_ARGUMENT);
|
|
test_parse("if!eth0!blubb", NULL, "eth0!blubb", NULL, CURLE_OK);
|
|
test_parse("host!", NULL, NULL, NULL, CURLE_BAD_FUNCTION_ARGUMENT);
|
|
test_parse("ifhost!", NULL, NULL, NULL, CURLE_BAD_FUNCTION_ARGUMENT);
|
|
test_parse("ifhost!eth0", NULL, NULL, NULL, CURLE_BAD_FUNCTION_ARGUMENT);
|
|
test_parse("ifhost!eth0!", NULL, NULL, NULL, CURLE_BAD_FUNCTION_ARGUMENT);
|
|
}
|
|
UNITTEST_STOP
|