mirror of
https://github.com/curl/curl.git
synced 2026-04-14 00:51:42 +08:00
4deea9396b
To make the source code match the functions called at runtime. And to avoid the preprocessor trick that may introduces build issues. Before this patch, libtests, tunits and units were calling a mixture of curl and system printf calls, then transformed them all to curl printf calls by including `curl_printf.h`. Changes made: - tests: stop including `curl_printf.h`. - libtest: switch a couple of outlier system printf calls to curl printf. - unit: use more curl printf to avoid casts and show whole values. - unit: switch remaining calls to curl printf explicitly. - tunit: switch to call curl printf explicitly. - libtest, tunit, unit: ban system printf. - unit1307, unit1607, unit1609, unit1652, unit1655, unit3214: bump types/masks to avoid casts. After this patch: - libtests, tunits, units: use exclusively curl printf. (as before, but explicitly, without relying on redefinitions.) - servers: is unchanged (it can only use system printf). Closes #18814
235 lines
6.9 KiB
C
235 lines
6.9 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "unitcheck.h"
|
|
|
|
#include "urldata.h"
|
|
#include "connect.h"
|
|
#include "share.h"
|
|
|
|
#include "memdebug.h" /* LAST include file */
|
|
|
|
static CURLcode t1607_setup(void)
|
|
{
|
|
CURLcode res = CURLE_OK;
|
|
global_init(CURL_GLOBAL_ALL);
|
|
return res;
|
|
}
|
|
|
|
static CURLcode test_unit1607(const char *arg)
|
|
{
|
|
/* In builds without IPv6 support CURLOPT_RESOLVE should skip over those
|
|
addresses, so we have to do that as well. */
|
|
static const char skip = 0;
|
|
#ifdef USE_IPV6
|
|
#define IPV6ONLY(x) x
|
|
#else
|
|
#define IPV6ONLY(x) &skip
|
|
#endif
|
|
|
|
UNITTEST_BEGIN(t1607_setup())
|
|
|
|
struct testcase {
|
|
/* host:port:address[,address]... */
|
|
const char *optval;
|
|
|
|
/* lowercase host and port to retrieve the addresses from hostcache */
|
|
const char *host;
|
|
int port;
|
|
|
|
/* whether we expect a permanent or non-permanent cache entry */
|
|
bool permanent;
|
|
|
|
/* 0 to 9 addresses expected from hostcache */
|
|
const char *address[10];
|
|
};
|
|
|
|
/* CURLOPT_RESOLVE address parsing tests */
|
|
static const struct testcase tests[] = {
|
|
/* spaces aren't allowed, for now */
|
|
{ "test.com:80:127.0.0.1, 127.0.0.2",
|
|
"test.com", 80, TRUE, { NULL, }
|
|
},
|
|
{ "TEST.com:80:,,127.0.0.1,,,127.0.0.2,,,,::1,,,",
|
|
"test.com", 80, TRUE, { "127.0.0.1", "127.0.0.2", IPV6ONLY("::1"), }
|
|
},
|
|
{ "test.com:80:::1,127.0.0.1",
|
|
"test.com", 80, TRUE, { IPV6ONLY("::1"), "127.0.0.1", }
|
|
},
|
|
{ "test.com:80:[::1],127.0.0.1",
|
|
"test.com", 80, TRUE, { IPV6ONLY("::1"), "127.0.0.1", }
|
|
},
|
|
{ "test.com:80:::1",
|
|
"test.com", 80, TRUE, { IPV6ONLY("::1"), }
|
|
},
|
|
{ "test.com:80:[::1]",
|
|
"test.com", 80, TRUE, { IPV6ONLY("::1"), }
|
|
},
|
|
{ "test.com:80:127.0.0.1",
|
|
"test.com", 80, TRUE, { "127.0.0.1", }
|
|
},
|
|
{ "test.com:80:,127.0.0.1",
|
|
"test.com", 80, TRUE, { "127.0.0.1", }
|
|
},
|
|
{ "test.com:80:127.0.0.1,",
|
|
"test.com", 80, TRUE, { "127.0.0.1", }
|
|
},
|
|
{ "test.com:0:127.0.0.1",
|
|
"test.com", 0, TRUE, { "127.0.0.1", }
|
|
},
|
|
{ "+test.com:80:127.0.0.1,",
|
|
"test.com", 80, FALSE, { "127.0.0.1", }
|
|
},
|
|
};
|
|
|
|
size_t i;
|
|
struct Curl_multi *multi = NULL;
|
|
struct Curl_easy *easy = NULL;
|
|
struct curl_slist *list = NULL;
|
|
|
|
for(i = 0; i < CURL_ARRAYSIZE(tests); ++i) {
|
|
size_t j;
|
|
size_t addressnum = CURL_ARRAYSIZE(tests[i].address);
|
|
struct Curl_addrinfo *addr;
|
|
struct Curl_dns_entry *dns;
|
|
void *entry_id;
|
|
bool problem = false;
|
|
easy = curl_easy_init();
|
|
if(!easy)
|
|
goto error;
|
|
|
|
/* create a multi handle and add the easy handle to it so that the
|
|
hostcache is setup */
|
|
multi = curl_multi_init();
|
|
curl_multi_add_handle(multi, easy);
|
|
|
|
list = curl_slist_append(NULL, tests[i].optval);
|
|
if(!list)
|
|
goto error;
|
|
curl_easy_setopt(easy, CURLOPT_RESOLVE, list);
|
|
|
|
Curl_loadhostpairs(easy);
|
|
|
|
entry_id = (void *)curl_maprintf("%s:%d", tests[i].host, tests[i].port);
|
|
if(!entry_id)
|
|
goto error;
|
|
dns = Curl_hash_pick(&multi->dnscache.entries,
|
|
entry_id, strlen(entry_id) + 1);
|
|
free(entry_id);
|
|
entry_id = NULL;
|
|
|
|
addr = dns ? dns->addr : NULL;
|
|
|
|
for(j = 0; j < addressnum; ++j) {
|
|
int port = 0;
|
|
char ipaddress[MAX_IPADR_LEN] = {0};
|
|
|
|
if(!addr && !tests[i].address[j])
|
|
break;
|
|
|
|
if(tests[i].address[j] == &skip)
|
|
continue;
|
|
|
|
if(addr && !Curl_addr2string(addr->ai_addr, addr->ai_addrlen,
|
|
ipaddress, &port)) {
|
|
curl_mfprintf(stderr, "%s:%d tests[%zu] failed. "
|
|
"getaddressinfo failed.\n",
|
|
__FILE__, __LINE__, i);
|
|
problem = true;
|
|
break;
|
|
}
|
|
|
|
if(addr && !tests[i].address[j]) {
|
|
curl_mfprintf(stderr, "%s:%d tests[%zu] failed. the retrieved addr "
|
|
"is %s but tests[%zu].address[%zu] is NULL.\n",
|
|
__FILE__, __LINE__, i, ipaddress, i, j);
|
|
problem = true;
|
|
break;
|
|
}
|
|
|
|
if(!addr && tests[i].address[j]) {
|
|
curl_mfprintf(stderr, "%s:%d tests[%zu] failed. the retrieved addr "
|
|
"is NULL but tests[%zu].address[%zu] is %s.\n",
|
|
__FILE__, __LINE__, i, i, j, tests[i].address[j]);
|
|
problem = true;
|
|
break;
|
|
}
|
|
|
|
if(!curl_strequal(ipaddress, tests[i].address[j])) {
|
|
curl_mfprintf(stderr, "%s:%d tests[%zu] failed. the retrieved addr "
|
|
"%s is not equal to tests[%zu].address[%zu] %s.\n",
|
|
__FILE__, __LINE__, i, ipaddress, i, j,
|
|
tests[i].address[j]);
|
|
problem = true;
|
|
break;
|
|
}
|
|
|
|
if(port != tests[i].port) {
|
|
curl_mfprintf(stderr, "%s:%d tests[%zu] failed. the retrieved port "
|
|
"for tests[%zu].address[%zu] is %d "
|
|
"but tests[%zu].port is %d.\n",
|
|
__FILE__, __LINE__, i, i, j, port, i, tests[i].port);
|
|
problem = true;
|
|
break;
|
|
}
|
|
|
|
if(dns->timestamp.tv_sec && tests[i].permanent) {
|
|
curl_mfprintf(stderr,
|
|
"%s:%d tests[%zu] failed. the timestamp is not zero "
|
|
"but tests[%zu].permanent is TRUE\n",
|
|
__FILE__, __LINE__, i, i);
|
|
problem = true;
|
|
break;
|
|
}
|
|
|
|
if(dns->timestamp.tv_sec == 0 && !tests[i].permanent) {
|
|
curl_mfprintf(stderr, "%s:%d tests[%zu] failed. the timestamp is zero "
|
|
"but tests[%zu].permanent is FALSE\n",
|
|
__FILE__, __LINE__, i, i);
|
|
problem = true;
|
|
break;
|
|
}
|
|
|
|
addr = addr->ai_next;
|
|
}
|
|
|
|
curl_easy_cleanup(easy);
|
|
easy = NULL;
|
|
curl_multi_cleanup(multi);
|
|
multi = NULL;
|
|
curl_slist_free_all(list);
|
|
list = NULL;
|
|
|
|
if(problem) {
|
|
unitfail++;
|
|
continue;
|
|
}
|
|
}
|
|
error:
|
|
curl_easy_cleanup(easy);
|
|
curl_multi_cleanup(multi);
|
|
curl_slist_free_all(list);
|
|
|
|
UNITTEST_END(curl_global_cleanup())
|
|
}
|