mirror of
https://github.com/curl/curl.git
synced 2026-04-12 12:21:42 +08:00
```
tests/unit/unit1654.c:41:5: warning: redundant condition 'result' [bugprone-redundant-branch-condition]
41 | fail_if(result, "Curl_altsvc_load");
| ^
tests/libtest/unitcheck.h:29:5: note: expanded from macro 'fail_if'
29 | if(expr) { \
| ^
```
Ref: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/redundant-branch-condition.html
Closes #20648
147 lines
5.9 KiB
C
147 lines
5.9 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "unitcheck.h"
|
|
|
|
#include "urldata.h"
|
|
#include "altsvc.h"
|
|
|
|
static CURLcode test_unit1654(const char *arg)
|
|
{
|
|
UNITTEST_BEGIN_SIMPLE
|
|
|
|
#if !defined(CURL_DISABLE_HTTP) && !defined(CURL_DISABLE_ALTSVC)
|
|
char outname[256];
|
|
CURL *curl;
|
|
CURLcode result;
|
|
struct altsvcinfo *asi = Curl_altsvc_init();
|
|
abort_if(!asi, "Curl_altsvc_i");
|
|
result = Curl_altsvc_load(asi, arg);
|
|
fail_if(result, "Curl_altsvc_load");
|
|
if(result)
|
|
goto fail;
|
|
curl_global_init(CURL_GLOBAL_ALL);
|
|
curl = curl_easy_init();
|
|
fail_if(!curl, "curl_easy_init");
|
|
if(!curl)
|
|
goto fail;
|
|
fail_unless(Curl_llist_count(&asi->list) == 4, "wrong number of entries");
|
|
curl_msnprintf(outname, sizeof(outname), "%s-out", arg);
|
|
|
|
result = Curl_altsvc_parse(curl, asi, "h2=\"example.com:8080\"\r\n",
|
|
ALPN_h1, "example.org", 8080);
|
|
fail_if(result, "Curl_altsvc_parse() failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 5, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi, "h3=\":8080\"\r\n",
|
|
ALPN_h1, "2.example.org", 8080);
|
|
fail_if(result, "Curl_altsvc_parse(2) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 6, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.com:8080\", "
|
|
"h3=\"yesyes.com:8080\"\r\n",
|
|
ALPN_h1, "3.example.org", 8080);
|
|
fail_if(result, "Curl_altsvc_parse(3) failed!");
|
|
/* that one should make two entries */
|
|
fail_unless(Curl_llist_count(&asi->list) == 8, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.com:443\"; ma = 120;\r\n",
|
|
ALPN_h2, "example.org", 80);
|
|
fail_if(result, "Curl_altsvc_parse(4) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 9, "wrong number of entries");
|
|
|
|
/* quoted 'ma' value */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net:443\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(5) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 10, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\":443\"; ma=180, h3=\":443\"; "
|
|
"persist = \"1\"; ma = 120;\r\n",
|
|
ALPN_h1, "curl.se", 80);
|
|
fail_if(result, "Curl_altsvc_parse(6) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 12, "wrong number of entries");
|
|
|
|
/* clear that one again and decrease the counter */
|
|
result = Curl_altsvc_parse(curl, asi, "clear;\r\n",
|
|
ALPN_h1, "curl.se", 80);
|
|
fail_if(result, "Curl_altsvc_parse(7) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 10, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\":443\", h3=\":443\"; "
|
|
"persist = \"1\"; ma = 120;\r\n",
|
|
ALPN_h1, "curl.se", 80);
|
|
fail_if(result, "Curl_altsvc_parse(6) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 12, "wrong number of entries");
|
|
|
|
/* clear - without semicolon */
|
|
result = Curl_altsvc_parse(curl, asi, "clear\r\n",
|
|
ALPN_h1, "curl.se", 80);
|
|
fail_if(result, "Curl_altsvc_parse(7) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 10, "wrong number of entries");
|
|
|
|
/* only a non-existing alpn */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h6=\"example.net:443\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "5.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(8) failed!");
|
|
|
|
/* missing quote in alpn host */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net:443,; ma=\"180\";\r\n",
|
|
ALPN_h2, "6.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(9) failed!");
|
|
|
|
/* missing port in hostname */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "7.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(10) failed!");
|
|
|
|
/* illegal port in hostname */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net:70000\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "8.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(11) failed!");
|
|
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"test2.se:443\"; ma=\"180 \" ; unknown=2, "
|
|
"h2=\"test3.se:443\"; ma = 120;\r\n",
|
|
ALPN_h2, "test.se", 443);
|
|
fail_if(result, "Curl_altsvc_parse(12) failed!");
|
|
|
|
Curl_altsvc_save(curl, asi, outname);
|
|
|
|
curl_easy_cleanup(curl);
|
|
fail:
|
|
Curl_altsvc_cleanup(&asi);
|
|
#endif
|
|
|
|
UNITTEST_END(curl_global_cleanup())
|
|
}
|