curl-curl/tests/unit
Stefan Eissing 2de22a00c7
lib: keep timestamp in easy handle
Use `data->progress.now` as the timestamp of proecssing a transfer.
Update it on significant events and refrain from calling `curlx_now()`
in many places.

The problem this addresses is
a) calling curlx_now() has costs, depending on platform. Calling it
   every time results in 25% increase `./runtest` duration on macOS.
b) we used to pass a `struct curltime *` around to save on calls, but
   when some method directly use `curx_now()` and some use the passed
   pointer, the transfer experienes non-linear time. This results in
   timeline checks to report events in the wrong order.

By keeping a timestamp in the easy handle and updating it there, no
longer invoking `curlx_now()` in the "lower" methods, the transfer
can observer a steady clock progression.

Add documentation in docs/internals/TIME-KEEPING.md

Reported-by: Viktor Szakats
Fixes #19935
Closes #19961
2025-12-16 08:48:44 +01:00
..
.gitignore tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
CMakeLists.txt build: tidy up compiler definition for tests 2025-07-28 12:43:01 +02:00
Makefile.am lib: stop overriding system printf symbols 2025-10-06 20:57:59 +02:00
Makefile.inc ratelimit: redesign 2025-11-24 23:34:05 +01:00
README.md badwords: fix issues found in tests 2025-11-17 13:30:35 +01:00
unit1300.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1302.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1303.c lib: keep timestamp in easy handle 2025-12-16 08:48:44 +01:00
unit1304.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit1305.c build: stop overriding standard memory allocation functions 2025-11-28 10:44:26 +01:00
unit1307.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1309.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1323.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1330.c build: stop overriding standard memory allocation functions 2025-11-28 10:44:26 +01:00
unit1395.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1396.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1397.c tidy-up: miscellaneous 2025-12-12 04:18:48 +01:00
unit1398.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1399.c lib: keep timestamp in easy handle 2025-12-16 08:48:44 +01:00
unit1600.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1601.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1602.c build: stop overriding standard memory allocation functions 2025-11-28 10:44:26 +01:00
unit1603.c build: stop overriding standard memory allocation functions 2025-11-28 10:44:26 +01:00
unit1605.c badwords: fix issues found in tests 2025-11-17 13:30:35 +01:00
unit1606.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1607.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1608.c tests: constify command-line arguments 2025-07-29 13:44:50 +02:00
unit1609.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1610.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1611.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1612.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1614.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1615.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1616.c build: stop overriding standard memory allocation functions 2025-11-28 10:44:26 +01:00
unit1620.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1650.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1651.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1652.c badwords: fix issues found in tests 2025-11-17 13:30:35 +01:00
unit1653.c build: stop overriding standard memory allocation functions 2025-11-28 10:44:26 +01:00
unit1654.c badwords: fix issues found in tests 2025-11-17 13:30:35 +01:00
unit1655.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit1656.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit1657.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit1658.c badwords: fix issues found in tests 2025-11-17 13:30:35 +01:00
unit1660.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1661.c bufref: rename *memdup() to *memdup0() 2025-12-04 16:49:16 +01:00
unit1663.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit1664.c build: stop overriding standard memory allocation functions 2025-11-28 10:44:26 +01:00
unit1979.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit1980.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit2600.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit2601.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit2602.c tests: fix formatting nits 2025-11-28 23:15:35 +01:00
unit2603.c http1: parse header from uint8_t buffer 2025-11-28 16:07:07 +01:00
unit2604.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit2605.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit3200.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit3205.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit3211.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit3212.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit3213.c tidy-up: one more round of formatting nits 2025-12-04 19:30:59 +01:00
unit3214.c test3214: allow a larger struct Curl_easy 2025-12-11 09:41:45 +01:00
unit3216.c lib: keep timestamp in easy handle 2025-12-16 08:48:44 +01:00

Unit tests

The goal is to add tests for all functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones.

Build Unit Tests

./configure --enable-debug is required for the unit tests to build. To enable unit tests, there is a separate static libcurl built that is used exclusively for linking unit test programs. Just build everything as normal, and then you can run the unit test cases as well.

Run Unit Tests

Unit tests are run as part of the regular test suite. If you have built everything to run unit tests, to can do 'make test' at the root level. Or you can cd tests and make and then invoke individual unit tests with ./runtests.pl NNNN where NNNN is the specific test number.

Debug Unit Tests

If a specific test fails you get told. The test case then has output left in the %LOGDIR subdirectory, but most importantly you can re-run the test again using gdb by doing ./runtests.pl -g NNNN. That is, add a -g to make it start up gdb and run the same case using that.

Write Unit Tests

We put tests that focus on an area or a specific function into a single C source file. The source file should be named unitNNNN.c where NNNN is a previously unused number.

Add your test to tests/unit/Makefile.inc (if it is a unit test). Add your test data filename to tests/data/Makefile.am

You also need a separate file called tests/data/testNNNN (using the same number) that describes your test case. See the test1300 file for inspiration and the tests/FILEFORMAT.md documentation.

For the actual C file, here's a simple example:

    #include "unitcheck.h"

    #include "a libcurl header.h" /* from the lib directory */

    static CURLcode test_unit9998(const char *arg)
    {
      UNITTEST_BEGIN_SIMPLE

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

      UNITTEST_END_SIMPLE
    }

Here's an example using optional initialization and cleanup:

    #include "unitcheck.h"

    #include "a libcurl header.h" /* from the lib directory */

    static CURLcode t9999_setup(void)
    {
      /* whatever you want done first */
      return CURLE_OK;
    }

    static void t9999_stop(void)
    {
      /* done before shutting down and exiting */
    }

    static CURLcode test_unit9999(const char *arg)
    {
      UNITTEST_BEGIN(t9999_setup())

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

      UNITTEST_END(t9999_stop())
    }