mirror of
https://github.com/curl/curl.git
synced 2026-04-13 12:41:42 +08:00
c9eff26c17
Replace `WSASocketW()` with `CURL_SOCKET()`. Also replace a call
to `socketclose()` with `sclose()`. According to a comment,
`socketclose()` was chosen to silence test 1498 (and 2300) reporting
`MEMORY FAILURE`. These reports were accurate, and were caused by
calling `WSASocketW()` instead of `socket()` (now `CURL_SOCKET()`).
This also fixes the curl `sclose()` call on an error branch, which is
now correctly paired with a curl socket open. The mismatched open/close
calls caused an issue in TrackMemory-enabled (aka `CURLDEBUG`) builds.
Docs confirm that `socket()` is defaulting to overlapped I/O, matching
the replaced `WSASocketW()` call:
https://learn.microsoft.com/windows/win32/api/winsock2/nf-winsock2-socket#remarks
Also:
- checksrc: ban `WSASocket*()` functions.
- report `SOCKERRNO` instead of `GetLastError()` for socket calls,
to match the rest of the codebase.
Follow-up to
|
||
|---|---|---|
| .. | ||
| cd2cd | ||
| cd2nroff | ||
| cdall | ||
| checksrc-all.pl | ||
| checksrc.pl | ||
| ciconfig.pl | ||
| cijobs.pl | ||
| cmakelint.sh | ||
| CMakeLists.txt | ||
| completion.pl | ||
| contributors.sh | ||
| contrithanks.sh | ||
| coverage.sh | ||
| delta | ||
| dmaketgz | ||
| extract-unit-protos | ||
| firefox-db2pem.sh | ||
| installcheck.sh | ||
| Makefile.am | ||
| maketgz | ||
| managen | ||
| mdlinkcheck | ||
| mk-ca-bundle.pl | ||
| mk-unity.pl | ||
| nroff2cd | ||
| pythonlint.sh | ||
| randdisable | ||
| release-notes.pl | ||
| release-tools.sh | ||
| schemetable.c | ||
| singleuse.pl | ||
| top-complexity | ||
| verify-release | ||
| wcurl | ||