mirror of
https://github.com/curl/curl.git
synced 2026-04-14 13:01:42 +08:00
Before this patch curl used the C preprocessor to override standard memory allocation symbols: malloc, calloc, strdup, realloc, free. The goal of these is to replace them with curl's debug wrappers in `CURLDEBUG` builds, another was to replace them with the wrappers calling user-defined allocators in libcurl. This solution needed a bunch of workarounds to avoid breaking external headers: it relied on include order to do the overriding last. For "unity" builds it needed to reset overrides before external includes. Also in test apps, which are always built as single source files. It also needed the `(symbol)` trick to avoid overrides in some places. This would still not fix cases where the standard symbols were macros. It was also fragile and difficult to figure out which was the actual function behind an alloc or free call in a specific piece of code. This in turn caused bugs where the wrong allocator was accidentally called. To avoid these problems, this patch replaces this solution with `curlx_`-prefixed allocator macros, and mapping them _once_ to either the libcurl wrappers, the debug wrappers or the standard ones, matching the rest of the code in libtests. This concludes the long journey to avoid redefining standard functions in the curl codebase. Note: I did not update `packages/OS400/*.c` sources. They did not `#include` `curl_setup.h`, `curl_memory.h` or `memdebug.h`, meaning the overrides were never applied to them. This may or may not have been correct. For now I suppressed the direct use of standard allocators via a local `.checksrc`. Probably they (except for `curlcl.c`) should be updated to include `curl_setup.h` and use the `curlx_` macros. This patch changes mappings in two places: - `lib/curl_threads.c` in libtests: Before this patch it mapped to libcurl allocators. After, it maps to standard allocators, like the rest of libtests code. - `units`: before this patch it mapped to standard allocators. After, it maps to libcurl allocators. Also: - drop all position-dependent `curl_memory.h` and `memdebug.h` includes, and delete the now unnecessary headers. - rename `Curl_tcsdup` macro to `curlx_tcsdup` and define like the other allocators. - map `curlx_strdup()` to `_strdup()` on Windows (was: `strdup()`). To fix warnings silenced via `_CRT_NONSTDC_NO_DEPRECATE`. - multibyte: map `curlx_convert_*()` to `_strdup()` on Windows (was: `strdup()`). - src: do not reuse the `strdup` name for the local replacement. - lib509: call `_strdup()` on Windows (was: `strdup()`). - test1132: delete test obsoleted by this patch. - CHECKSRC.md: update text for `SNPRINTF`. - checksrc: ban standard allocator symbols. Follow-up tob12da22db1#18866 Follow-up todb98daab05#18844 Follow-up to4deea9396b#18814 Follow-up to9678ff5b1b#18776 Follow-up to10bac43b87#18774 Follow-up to20142f5d06#18634 Follow-up tobf7375ecc5#18503 Follow-up to9863599d69#18502 Follow-up to3bb5e58c10#17827 Closes #19626
485 lines
15 KiB
C
485 lines
15 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "first.h"
|
|
|
|
#include "testutil.h"
|
|
|
|
#ifndef FD_SETSIZE
|
|
#error "this test requires FD_SETSIZE"
|
|
#endif
|
|
|
|
#define T518_SAFETY_MARGIN (16)
|
|
|
|
#define NUM_OPEN (FD_SETSIZE + 10)
|
|
#define NUM_NEEDED (NUM_OPEN + T518_SAFETY_MARGIN)
|
|
|
|
#if defined(_WIN32) || defined(MSDOS)
|
|
#define DEV_NULL "NUL"
|
|
#else
|
|
#define DEV_NULL "/dev/null"
|
|
#endif
|
|
|
|
#if defined(HAVE_GETRLIMIT) && defined(HAVE_SETRLIMIT)
|
|
|
|
static int *t518_testfd = NULL;
|
|
static struct rlimit t518_num_open;
|
|
static char t518_msgbuff[256];
|
|
|
|
static void t518_store_errmsg(const char *msg, int err)
|
|
{
|
|
if(!err)
|
|
curl_msnprintf(t518_msgbuff, sizeof(t518_msgbuff), "%s", msg);
|
|
else {
|
|
char errbuf[STRERROR_LEN];
|
|
curl_msnprintf(t518_msgbuff, sizeof(t518_msgbuff), "%s, errno %d, %s", msg,
|
|
err, curlx_strerror(err, errbuf, sizeof(errbuf)));
|
|
}
|
|
}
|
|
|
|
static void t518_close_file_descriptors(void)
|
|
{
|
|
for(t518_num_open.rlim_cur = 0;
|
|
t518_num_open.rlim_cur < t518_num_open.rlim_max;
|
|
t518_num_open.rlim_cur++)
|
|
if(t518_testfd[t518_num_open.rlim_cur] > 0)
|
|
close(t518_testfd[t518_num_open.rlim_cur]);
|
|
curlx_free(t518_testfd);
|
|
t518_testfd = NULL;
|
|
}
|
|
|
|
static int t518_fopen_works(void)
|
|
{
|
|
FILE *fpa[3];
|
|
int i;
|
|
int ret = 1;
|
|
|
|
for(i = 0; i < 3; i++) {
|
|
fpa[i] = NULL;
|
|
}
|
|
for(i = 0; i < 3; i++) {
|
|
fpa[i] = curlx_fopen(DEV_NULL, FOPEN_READTEXT);
|
|
if(!fpa[i]) {
|
|
t518_store_errmsg("fopen failed", errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
ret = 0;
|
|
break;
|
|
}
|
|
}
|
|
for(i = 0; i < 3; i++) {
|
|
if(fpa[i])
|
|
curlx_fclose(fpa[i]);
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
static int t518_test_rlimit(int keep_open)
|
|
{
|
|
rlim_t nitems, i;
|
|
int *memchunk = NULL;
|
|
struct rlimit rl;
|
|
char strbuff[256];
|
|
char strbuff1[81];
|
|
char strbuff2[81];
|
|
|
|
/* get initial open file limits */
|
|
|
|
if(getrlimit(RLIMIT_NOFILE, &rl) != 0) {
|
|
t518_store_errmsg("getrlimit() failed", errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
return -1;
|
|
}
|
|
|
|
/* show initial open file limits */
|
|
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), rl.rlim_cur);
|
|
curl_mfprintf(stderr, "initial soft limit: %s\n", strbuff);
|
|
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), rl.rlim_max);
|
|
curl_mfprintf(stderr, "initial hard limit: %s\n", strbuff);
|
|
|
|
/* show our constants */
|
|
|
|
curl_mfprintf(stderr, "test518 FD_SETSIZE: %d\n", FD_SETSIZE);
|
|
curl_mfprintf(stderr, "test518 NUM_OPEN : %d\n", NUM_OPEN);
|
|
curl_mfprintf(stderr, "test518 NUM_NEEDED: %d\n", NUM_NEEDED);
|
|
|
|
/*
|
|
* if soft limit and hard limit are different we ask the
|
|
* system to raise soft limit all the way up to the hard
|
|
* limit. Due to some other system limit the soft limit
|
|
* might not be raised up to the hard limit. So from this
|
|
* point the resulting soft limit is our limit. Trying to
|
|
* open more than soft limit file descriptors will fail.
|
|
*/
|
|
|
|
if(rl.rlim_cur != rl.rlim_max) {
|
|
|
|
#ifdef OPEN_MAX
|
|
if((rl.rlim_cur > 0) &&
|
|
(rl.rlim_cur < OPEN_MAX)) {
|
|
curl_mfprintf(stderr, "raising soft limit up to OPEN_MAX\n");
|
|
rl.rlim_cur = OPEN_MAX;
|
|
if(setrlimit(RLIMIT_NOFILE, &rl) != 0) {
|
|
/* on failure do not abort just issue a warning */
|
|
t518_store_errmsg("setrlimit() failed", errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
t518_msgbuff[0] = '\0';
|
|
}
|
|
}
|
|
#endif
|
|
|
|
curl_mfprintf(stderr, "raising soft limit up to hard limit\n");
|
|
rl.rlim_cur = rl.rlim_max;
|
|
if(setrlimit(RLIMIT_NOFILE, &rl) != 0) {
|
|
/* on failure do not abort just issue a warning */
|
|
t518_store_errmsg("setrlimit() failed", errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
t518_msgbuff[0] = '\0';
|
|
}
|
|
|
|
/* get current open file limits */
|
|
|
|
if(getrlimit(RLIMIT_NOFILE, &rl) != 0) {
|
|
t518_store_errmsg("getrlimit() failed", errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
return -3;
|
|
}
|
|
|
|
/* show current open file limits */
|
|
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), rl.rlim_cur);
|
|
curl_mfprintf(stderr, "current soft limit: %s\n", strbuff);
|
|
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), rl.rlim_max);
|
|
curl_mfprintf(stderr, "current hard limit: %s\n", strbuff);
|
|
|
|
} /* (rl.rlim_cur != rl.rlim_max) */
|
|
|
|
/*
|
|
* test 518 is all about testing libcurl functionality
|
|
* when more than FD_SETSIZE file descriptors are open.
|
|
* This means that if for any reason we are not able to
|
|
* open more than FD_SETSIZE file descriptors then test
|
|
* 518 should not be run.
|
|
*/
|
|
|
|
/*
|
|
* verify that soft limit is higher than NUM_NEEDED,
|
|
* which is the number of file descriptors we would
|
|
* try to open plus T518_SAFETY_MARGIN to not exhaust the
|
|
* file descriptor pool
|
|
*/
|
|
|
|
t518_num_open.rlim_cur = NUM_NEEDED;
|
|
|
|
if((rl.rlim_cur > 0) &&
|
|
#ifdef RLIM_INFINITY
|
|
(rl.rlim_cur != RLIM_INFINITY) &&
|
|
#endif
|
|
(rl.rlim_cur <= t518_num_open.rlim_cur)) {
|
|
tutil_rlim2str(strbuff2, sizeof(strbuff2), rl.rlim_cur);
|
|
tutil_rlim2str(strbuff1, sizeof(strbuff1), t518_num_open.rlim_cur);
|
|
curl_msnprintf(strbuff, sizeof(strbuff), "fds needed %s > system limit %s",
|
|
strbuff1, strbuff2);
|
|
t518_store_errmsg(strbuff, 0);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
return -4;
|
|
}
|
|
|
|
/*
|
|
* reserve a chunk of memory before opening file descriptors to
|
|
* avoid a low memory condition once the file descriptors are
|
|
* open. System conditions that could make the test fail should
|
|
* be addressed in the precheck phase. This chunk of memory shall
|
|
* be always curlx_free()ed before exiting the t518_test_rlimit()
|
|
* function so that it becomes available to the test.
|
|
*/
|
|
|
|
for(nitems = i = 1; nitems <= i; i *= 2)
|
|
nitems = i;
|
|
if(nitems > 0x7fff)
|
|
nitems = 0x40000;
|
|
do {
|
|
t518_num_open.rlim_max = sizeof(*memchunk) * nitems;
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), t518_num_open.rlim_max);
|
|
curl_mfprintf(stderr, "allocating memchunk %s byte array\n", strbuff);
|
|
memchunk = curlx_malloc(sizeof(*memchunk) * (size_t)nitems);
|
|
if(!memchunk) {
|
|
curl_mfprintf(stderr, "memchunk, malloc() failed\n");
|
|
nitems /= 2;
|
|
}
|
|
} while(nitems && !memchunk);
|
|
if(!memchunk) {
|
|
t518_store_errmsg("memchunk, malloc() failed", errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
return -5;
|
|
}
|
|
|
|
/* initialize it to fight lazy allocation */
|
|
|
|
curl_mfprintf(stderr, "initializing memchunk array\n");
|
|
|
|
for(i = 0; i < nitems; i++)
|
|
memchunk[i] = -1;
|
|
|
|
/* set the number of file descriptors we will try to open */
|
|
|
|
t518_num_open.rlim_max = NUM_OPEN;
|
|
|
|
/* verify that we do not overflow size_t in curlx_malloc() */
|
|
|
|
if((size_t)(t518_num_open.rlim_max) > ((size_t)-1) / sizeof(*t518_testfd)) {
|
|
tutil_rlim2str(strbuff1, sizeof(strbuff1), t518_num_open.rlim_max);
|
|
curl_msnprintf(strbuff, sizeof(strbuff),
|
|
"unable to allocate an array for %s "
|
|
"file descriptors, would overflow size_t", strbuff1);
|
|
t518_store_errmsg(strbuff, 0);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
curlx_free(memchunk);
|
|
return -6;
|
|
}
|
|
|
|
/* allocate array for file descriptors */
|
|
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), t518_num_open.rlim_max);
|
|
curl_mfprintf(stderr, "allocating array for %s file descriptors\n", strbuff);
|
|
|
|
t518_testfd = curlx_malloc(sizeof(*t518_testfd) *
|
|
(size_t)(t518_num_open.rlim_max));
|
|
if(!t518_testfd) {
|
|
t518_store_errmsg("testfd, malloc() failed", errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
curlx_free(memchunk);
|
|
return -7;
|
|
}
|
|
|
|
/* initialize it to fight lazy allocation */
|
|
|
|
curl_mfprintf(stderr, "initializing testfd array\n");
|
|
|
|
for(t518_num_open.rlim_cur = 0;
|
|
t518_num_open.rlim_cur < t518_num_open.rlim_max;
|
|
t518_num_open.rlim_cur++)
|
|
t518_testfd[t518_num_open.rlim_cur] = -1;
|
|
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), t518_num_open.rlim_max);
|
|
curl_mfprintf(stderr, "trying to open %s file descriptors\n", strbuff);
|
|
|
|
/* open a dummy descriptor */
|
|
|
|
t518_testfd[0] = curlx_open(DEV_NULL, O_RDONLY);
|
|
if(t518_testfd[0] < 0) {
|
|
curl_msnprintf(strbuff, sizeof(strbuff), "opening of %s failed", DEV_NULL);
|
|
t518_store_errmsg(strbuff, errno);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
curlx_free(t518_testfd);
|
|
t518_testfd = NULL;
|
|
curlx_free(memchunk);
|
|
return -8;
|
|
}
|
|
|
|
/* create a bunch of file descriptors */
|
|
|
|
for(t518_num_open.rlim_cur = 1;
|
|
t518_num_open.rlim_cur < t518_num_open.rlim_max;
|
|
t518_num_open.rlim_cur++) {
|
|
|
|
t518_testfd[t518_num_open.rlim_cur] = dup(t518_testfd[0]);
|
|
|
|
if(t518_testfd[t518_num_open.rlim_cur] < 0) {
|
|
|
|
t518_testfd[t518_num_open.rlim_cur] = -1;
|
|
|
|
tutil_rlim2str(strbuff1, sizeof(strbuff1), t518_num_open.rlim_cur);
|
|
curl_msnprintf(strbuff, sizeof(strbuff), "dup() attempt %s failed",
|
|
strbuff1);
|
|
curl_mfprintf(stderr, "%s\n", strbuff);
|
|
|
|
tutil_rlim2str(strbuff1, sizeof(strbuff1), t518_num_open.rlim_cur);
|
|
curl_msnprintf(strbuff, sizeof(strbuff),
|
|
"fds system limit seems close to %s", strbuff1);
|
|
curl_mfprintf(stderr, "%s\n", strbuff);
|
|
|
|
t518_num_open.rlim_max = NUM_NEEDED;
|
|
|
|
tutil_rlim2str(strbuff2, sizeof(strbuff2), t518_num_open.rlim_max);
|
|
tutil_rlim2str(strbuff1, sizeof(strbuff1), t518_num_open.rlim_cur);
|
|
curl_msnprintf(strbuff, sizeof(strbuff),
|
|
"fds needed %s > system limit %s", strbuff2, strbuff1);
|
|
t518_store_errmsg(strbuff, 0);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
|
|
for(t518_num_open.rlim_cur = 0;
|
|
t518_testfd[t518_num_open.rlim_cur] >= 0;
|
|
t518_num_open.rlim_cur++)
|
|
close(t518_testfd[t518_num_open.rlim_cur]);
|
|
curlx_free(t518_testfd);
|
|
t518_testfd = NULL;
|
|
curlx_free(memchunk);
|
|
return -9;
|
|
}
|
|
}
|
|
|
|
tutil_rlim2str(strbuff, sizeof(strbuff), t518_num_open.rlim_max);
|
|
curl_mfprintf(stderr, "%s file descriptors open\n", strbuff);
|
|
|
|
#if !defined(HAVE_POLL) && !defined(USE_WINSOCK)
|
|
|
|
/*
|
|
* when using select() instead of poll() we cannot test
|
|
* libcurl functionality with a socket number equal or
|
|
* greater than FD_SETSIZE. In any case, macro VERIFY_SOCK
|
|
* in lib/select.c enforces this check and protects libcurl
|
|
* from a possible crash. The effect of this protection
|
|
* is that test 518 will always fail, since the actual
|
|
* call to select() never takes place. We skip test 518
|
|
* with an indication that select limit would be exceeded.
|
|
*/
|
|
|
|
t518_num_open.rlim_cur = FD_SETSIZE - T518_SAFETY_MARGIN;
|
|
if(t518_num_open.rlim_max > t518_num_open.rlim_cur) {
|
|
curl_msnprintf(strbuff, sizeof(strbuff), "select limit is FD_SETSIZE %d",
|
|
FD_SETSIZE);
|
|
t518_store_errmsg(strbuff, 0);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
t518_close_file_descriptors();
|
|
curlx_free(memchunk);
|
|
return -10;
|
|
}
|
|
|
|
t518_num_open.rlim_cur = FD_SETSIZE - T518_SAFETY_MARGIN;
|
|
for(rl.rlim_cur = 0;
|
|
rl.rlim_cur < t518_num_open.rlim_max;
|
|
rl.rlim_cur++) {
|
|
if((t518_testfd[rl.rlim_cur] > 0) &&
|
|
((unsigned int)t518_testfd[rl.rlim_cur] > t518_num_open.rlim_cur)) {
|
|
curl_msnprintf(strbuff, sizeof(strbuff), "select limit is FD_SETSIZE %d",
|
|
FD_SETSIZE);
|
|
t518_store_errmsg(strbuff, 0);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
t518_close_file_descriptors();
|
|
curlx_free(memchunk);
|
|
return -11;
|
|
}
|
|
}
|
|
|
|
#endif /* using an FD_SETSIZE bound select() */
|
|
|
|
/*
|
|
* Old or 'backwards compatible' implementations of stdio do not allow
|
|
* handling of streams with an underlying file descriptor number greater
|
|
* than 255, even when allowing high numbered file descriptors for sockets.
|
|
* At this point we have a big number of file descriptors which have been
|
|
* opened using dup(), so lets test the stdio implementation and discover
|
|
* if it is capable of fopen()ing some additional files.
|
|
*/
|
|
|
|
if(!t518_fopen_works()) {
|
|
tutil_rlim2str(strbuff1, sizeof(strbuff1), t518_num_open.rlim_max);
|
|
curl_msnprintf(strbuff, sizeof(strbuff), "fopen fails with %s fds open",
|
|
strbuff1);
|
|
curl_mfprintf(stderr, "%s\n", t518_msgbuff);
|
|
curl_msnprintf(strbuff, sizeof(strbuff),
|
|
"fopen fails with lots of fds open");
|
|
t518_store_errmsg(strbuff, 0);
|
|
t518_close_file_descriptors();
|
|
curlx_free(memchunk);
|
|
return -12;
|
|
}
|
|
|
|
/* free the chunk of memory we were reserving so that it
|
|
becomes available to the test */
|
|
|
|
curlx_free(memchunk);
|
|
|
|
/* close file descriptors unless instructed to keep them */
|
|
|
|
if(!keep_open) {
|
|
t518_close_file_descriptors();
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static CURLcode test_lib518(const char *URL)
|
|
{
|
|
CURLcode res;
|
|
CURL *curl;
|
|
|
|
if(!strcmp(URL, "check")) {
|
|
/* used by the test script to ask if we can run this test or not */
|
|
if(t518_test_rlimit(FALSE)) {
|
|
curl_mfprintf(stdout, "test_rlimit problem: %s\n", t518_msgbuff);
|
|
return TEST_ERR_FAILURE;
|
|
}
|
|
return CURLE_OK; /* sure, run this! */
|
|
}
|
|
|
|
if(t518_test_rlimit(TRUE)) {
|
|
/* failure */
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
/* run the test with the bunch of open file descriptors
|
|
and close them all once the test is over */
|
|
|
|
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
|
curl_mfprintf(stderr, "curl_global_init() failed\n");
|
|
t518_close_file_descriptors();
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
curl_mfprintf(stderr, "curl_easy_init() failed\n");
|
|
t518_close_file_descriptors();
|
|
curl_global_cleanup();
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
test_setopt(curl, CURLOPT_URL, URL);
|
|
test_setopt(curl, CURLOPT_HEADER, 1L);
|
|
|
|
res = curl_easy_perform(curl);
|
|
|
|
test_cleanup:
|
|
|
|
t518_close_file_descriptors();
|
|
curl_easy_cleanup(curl);
|
|
curl_global_cleanup();
|
|
|
|
return res;
|
|
}
|
|
|
|
#else /* HAVE_GETRLIMIT && HAVE_SETRLIMIT */
|
|
|
|
static CURLcode test_lib518(const char *URL)
|
|
{
|
|
(void)URL;
|
|
curl_mprintf("system lacks necessary system function(s)");
|
|
return TEST_ERR_MAJOR_BAD; /* skip test */
|
|
}
|
|
|
|
#endif /* HAVE_GETRLIMIT && HAVE_SETRLIMIT */
|