mirror of
https://github.com/curl/curl.git
synced 2026-04-14 00:51:42 +08:00
e95f509c66
Before this patch the signal handler called `logmsg()` which in turn
called `printf()` variants (internal implementations), and `FILE *`
functions, `localtime()`. Some of these called `malloc`/`free`, which
isn't supported in s signal handler. Replace them with `write` calls,
losing some logging functionality.
Also:
- De-dupe and move `STD*_FILENO` macros to `lib/curl_setup.h`. Revert
the `src` definition to point to `stderr`, instead of `tool_stderr`.
Follow-up to e5bb88b8f8 #11958
POSIX specs with list of functions allowed in a signal handler:
2004: https://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_04.html#tag_02_04_03
2017: https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_04_03
2024: https://pubs.opengroup.org/onlinepubs/9799919799/functions/V2_chap02.html#tag_16_04_03
Linux CI run with the thread sanitizer going crazy when
hitting the signal handler in test 1238 and 1242 (TFTP):
```
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=12582)
#0 malloc <null> (servers+0x5ed70)
#1 _IO_file_doallocate <null> (libc.so.6+0x851b4)
#2 formatf /home/runner/work/curl/curl/bld/tests/server/../../lib/../../lib/mprintf.c:886:9 (servers+0xdff77)
[...]
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=12582)
#0 free <null> (servers+0x5f453)
#1 fclose <null> (libc.so.6+0x8532f)
#2 logmsg /home/runner/work/curl/curl/bld/tests/server/../../../tests/server/util.c:134:5 (servers+0xe684d)
```
Ref: https://github.com/curl/curl/actions/runs/14118903372/job/39555309490?pr=16851
Closes #16852
118 lines
3.1 KiB
C
118 lines
3.1 KiB
C
#ifndef HEADER_CURL_TOOL_SETUP_H
|
|
#define HEADER_CURL_TOOL_SETUP_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
#define CURL_NO_OLDIES
|
|
|
|
/*
|
|
* curl_setup.h may define preprocessor macros such as _FILE_OFFSET_BITS and
|
|
* _LARGE_FILES in order to support files larger than 2 GB. On platforms
|
|
* where this happens it is mandatory that these macros are defined before
|
|
* any system header file is included, otherwise file handling function
|
|
* prototypes will be misdeclared and curl tool may not build properly;
|
|
* therefore we must include curl_setup.h before curl.h when building curl.
|
|
*/
|
|
|
|
#include "curl_setup.h" /* from the lib directory */
|
|
|
|
extern FILE *tool_stderr;
|
|
|
|
/*
|
|
* curl tool certainly uses libcurl's external interface.
|
|
*/
|
|
|
|
#include <curl/curl.h> /* external interface */
|
|
|
|
#include "timeval.h"
|
|
|
|
/*
|
|
* Platform specific stuff.
|
|
*/
|
|
|
|
#ifdef macintosh
|
|
# define main(x,y) curl_main(x,y)
|
|
#endif
|
|
|
|
#ifndef CURL_OS
|
|
# define CURL_OS "unknown"
|
|
#endif
|
|
|
|
#ifndef UNPRINTABLE_CHAR
|
|
/* define what to use for unprintable characters */
|
|
# define UNPRINTABLE_CHAR '.'
|
|
#endif
|
|
|
|
#ifndef HAVE_STRDUP
|
|
# include "tool_strdup.h"
|
|
#endif
|
|
|
|
#ifndef tool_nop_stmt
|
|
#define tool_nop_stmt do { } while(0)
|
|
#endif
|
|
|
|
#ifdef _WIN32
|
|
# define CURL_STRICMP(p1, p2) _stricmp(p1, p2)
|
|
#elif defined(HAVE_STRCASECMP)
|
|
# ifdef HAVE_STRINGS_H
|
|
# include <strings.h>
|
|
# endif
|
|
# define CURL_STRICMP(p1, p2) strcasecmp(p1, p2)
|
|
#elif defined(HAVE_STRCMPI)
|
|
# define CURL_STRICMP(p1, p2) strcmpi(p1, p2)
|
|
#elif defined(HAVE_STRICMP)
|
|
# define CURL_STRICMP(p1, p2) stricmp(p1, p2)
|
|
#else
|
|
# define CURL_STRICMP(p1, p2) strcmp(p1, p2)
|
|
#endif
|
|
|
|
#ifdef _WIN32
|
|
/* set in init_terminal() */
|
|
extern bool tool_term_has_bold;
|
|
|
|
#ifdef UNDER_CE
|
|
# undef isatty
|
|
# define isatty(fd) 0 /* fd is void*, expects int */
|
|
# undef _get_osfhandle
|
|
# define _get_osfhandle(fd) (fd)
|
|
# undef _getch
|
|
# define _getch() 0
|
|
#endif
|
|
|
|
#ifndef HAVE_FTRUNCATE
|
|
|
|
int tool_ftruncate64(int fd, curl_off_t where);
|
|
|
|
#undef ftruncate
|
|
#define ftruncate(fd,where) tool_ftruncate64(fd,where)
|
|
|
|
#define HAVE_FTRUNCATE 1
|
|
#define USE_TOOL_FTRUNCATE 1
|
|
|
|
#endif /* ! HAVE_FTRUNCATE */
|
|
#endif /* _WIN32 */
|
|
|
|
|
|
#endif /* HEADER_CURL_TOOL_SETUP_H */
|