mirror of
https://github.com/curl/curl.git
synced 2026-04-11 12:01:42 +08:00
3058ed3df8
Backtrack on previous change that aimed to solve the wrong `share.h` being included. It turns out it did not fix this issue. At the same time it introduced relative header filenames and the need to include the same headers differently depending on the source files' location, reducing readability and editability. Replace this method by re-adding curl's lib source directory to the header path and addressing headers by the their full, relative name to that base directory. Aligning with this method already used in src and tests. With these advantages: - makes includes easier to read, recognize, grep, sort, write, and copy between sources, - syncs the way these headers are included across curl components, - avoids the ambiguity between system `schannel.h`, `rustls.h` vs. local headers using the same names in `lib/vtls`, - silences clang-tidy `readability-duplicate-include` checker, which detects the above issue, Ref: https://clang.llvm.org/extra/clang-tidy/checks/readability/duplicate-include.html - possibly silences TIOBE coding standard warnings: `6.10.2.a: Don't use relative paths in #include statements.` - long shot: it works well with concatenated test sources, for clang-tidy-friendly custom unity builds. Ref: #20667 Slight downside: it's not enforced. If there happens to be a collision between a local `lib/*.h` header and a system one, the solution is to rename (possibly with its `.c` counterpart) into the `curl_` namespace. This is also the method used by curl in the past. Also: - curlx/inet_pton: reduce scope of an include. - toolx/tool_time: apply this to an include, and update VS project files accordingly. Also dropping unnecessary lib/curlx header path. - clang-tidy: enable `readability-duplicate-include`. Follow-up to3887069c66#19676 Follow-up to625f2c1644#16991 #16949 Closes #20623
93 lines
2.6 KiB
C
93 lines
2.6 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curl_setup.h"
|
|
|
|
#ifdef HAVE_SYS_IOCTL_H
|
|
#include <sys/ioctl.h>
|
|
#endif
|
|
#ifdef HAVE_FCNTL_H
|
|
#include <fcntl.h>
|
|
#endif
|
|
|
|
#ifdef __VMS
|
|
#include <in.h>
|
|
#include <inet.h>
|
|
#endif
|
|
|
|
#include "curlx/nonblock.h"
|
|
|
|
/*
|
|
* curlx_nonblock() set the given socket to either blocking or non-blocking
|
|
* mode based on the 'nonblock' boolean argument. This function is highly
|
|
* portable.
|
|
*/
|
|
int curlx_nonblock(curl_socket_t sockfd, /* operate on this */
|
|
int nonblock /* TRUE or FALSE */)
|
|
{
|
|
#ifdef HAVE_FCNTL_O_NONBLOCK
|
|
/* most recent Unix versions */
|
|
int flags;
|
|
flags = sfcntl(sockfd, F_GETFL, 0);
|
|
if(flags < 0)
|
|
return -1;
|
|
/* Check if the current file status flags have already satisfied
|
|
* the request, if so, it is no need to call fcntl() to replicate it.
|
|
*/
|
|
if(!!(flags & O_NONBLOCK) == !!nonblock)
|
|
return 0;
|
|
if(nonblock)
|
|
flags |= O_NONBLOCK;
|
|
else
|
|
flags &= ~O_NONBLOCK;
|
|
return sfcntl(sockfd, F_SETFL, flags);
|
|
|
|
#elif defined(HAVE_IOCTLSOCKET_CAMEL_FIONBIO)
|
|
|
|
/* Amiga */
|
|
long flags = nonblock ? 1L : 0L;
|
|
return IoctlSocket(sockfd, FIONBIO, (char *)&flags);
|
|
|
|
#elif defined(HAVE_IOCTL_FIONBIO)
|
|
|
|
/* older Unix versions */
|
|
int flags = nonblock ? 1 : 0;
|
|
return ioctl(sockfd, FIONBIO, &flags);
|
|
|
|
#elif defined(HAVE_IOCTLSOCKET_FIONBIO)
|
|
|
|
/* Windows */
|
|
unsigned long flags = nonblock ? 1UL : 0UL;
|
|
return ioctlsocket(sockfd, (long)FIONBIO, &flags);
|
|
|
|
#elif defined(HAVE_SETSOCKOPT_SO_NONBLOCK)
|
|
|
|
/* Orbis OS */
|
|
long b = nonblock ? 1L : 0L;
|
|
return setsockopt(sockfd, SOL_SOCKET, SO_NONBLOCK, &b, sizeof(b));
|
|
|
|
#else
|
|
#error "no non-blocking method was found/used/set"
|
|
#endif
|
|
}
|