Stefan Eissing
2e1040fa5c
asny-thrdd: fix detach from running thread
...
When cancelling a threaded resolve and the thread is
still running, detach from it under the mutex lock.
Otherwise, the detach might happen after the thread finished
and access already freed memory.
Fixes #17256
Reported-by: Mathieu Garaud
Closes #17320
2025-05-12 17:17:19 +02:00
Daniel Stenberg
dc4272318f
imap: remove redundant condition
...
'imap' always evaluates to true. Spotted by CodeSonar.
Closes #17318
2025-05-12 11:04:33 +02:00
Daniel Stenberg
da06f01ab9
rtsp: remove redundant condition
...
'rtsp' always evaluates to true. Spotted by CodeSonar.
Closes #17317
2025-05-12 11:03:44 +02:00
Daniel Stenberg
c5398fa393
netrc: avoid strdup NULL
...
Coverity found a code path where this might happen. Avoid it.
Closes #17319
2025-05-12 11:02:51 +02:00
Daniel Stenberg
5f6c714d24
http_chunks: narrow variable scope for 'trlen'
...
CodeSonar found a case where it would be assigned but never used and
narrowing the scope makes sense anyway.
Closes #17316
2025-05-12 11:02:00 +02:00
Daniel Stenberg
f862f863bf
mprintf: provide hex digits for escape.c to use
...
Since they need the exact same set, use the same set. The mprintf string
was longer than it had to be.
Closes #17311
2025-05-12 07:44:35 +02:00
Daniel Stenberg
1eb3928db6
mprintf: remove outdated comment about SIZEOF_SIZE_T
...
It was now plain wrong
Closes #17312
2025-05-12 07:43:54 +02:00
Daniel Stenberg
c37f4b6ac3
inet_ntop: rename curlx_inet_ntop to Curl_inet_ntop
...
It is not part of the curlx club.
Closes #17313
2025-05-12 07:42:59 +02:00
Daniel Stenberg
3b3d6a46ba
timeval.c: #include fix
2025-05-11 12:24:10 +02:00
Daniel Stenberg
674836399f
mime: reuse the base64 string from the base64 code
...
Avoids duplicating an identical string here.
Closes #17309
2025-05-10 23:01:14 +02:00
Daniel Stenberg
ff84228a53
base64: pass in the padding byte separately
...
The makes the string with base64 octets "pure" to be used elsewhere as
well.
Closes #17309
2025-05-10 23:01:07 +02:00
Viktor Szakats
1499319442
windows: fix to preserve error code in curlx_winapi_strerror()
...
Drop the interim macro `PRESERVE_WINDOWS_ERROR_CODE` and always preserve
error code for `_WIN32`. To make sure this is always done in
`curlx_winapi_strerror()`.
Follow-up to c74d3e10d2#17299
Closes #17302
2025-05-09 15:56:07 +02:00
Daniel Stenberg
d4dd43b20d
curlx: move curlx_inet_pton
...
Used by test server code.
Closes #17300
2025-05-09 13:45:24 +02:00
Daniel Stenberg
c74d3e10d2
curlx: add curlx_winapi_ functions
...
Split them out from lib/strerror. Used by test code.
Closes #17299
2025-05-09 10:45:36 +02:00
Daniel Stenberg
a129859367
lib: drop curlx_getpid, use fake pid in SMB
...
It was not a function properly exposed in the curlx set. SMB cannot
possibly need to send a real pid, now sends a made up number.
The only real users of this function are test servers, so move the logic
over there.
Closes #17298
2025-05-09 10:01:30 +02:00
Daniel Stenberg
16db059a93
curlx: move version_win32.[ch] to curlx/
...
For curlx_verify_windows_version
Closes #17290
2025-05-08 17:09:32 +02:00
Daniel Stenberg
4190c73094
curlx: move nonblock.[ch] into curlx/
...
Closes #17288
2025-05-08 13:22:02 +02:00
Stefan Eissing
27bc798369
file: use easy handle meta for protocol struct
...
Closes #17292
2025-05-08 13:18:45 +02:00
Daniel Stenberg
1c6fc0cd2b
curlx: simplify the curlx_unicodefree macro
...
- explain its purpose in a comment
Closes #17287
2025-05-08 11:57:58 +02:00
Stefan Eissing
09fed29460
ssh: move easy handle/connection protocol structs to meta
...
Closes #17273
2025-05-08 11:56:50 +02:00
Daniel Stenberg
f0fc30e904
winbuild: curl_get_line is not used for tool builds
...
Drop it from the build. Also remove it from the tests/server makefile.
Follow-up to d8618f4d84Closes #17286
2025-05-08 10:53:57 +02:00
Stefan Eissing
778f306551
rtmp: remove no longer used proto member
...
Add src/curlinfo to gitignore while we are here.
Add tests/server/dnsd to gitignore while we are here.
Closes #17252
2025-05-08 10:24:19 +02:00
Daniel Stenberg
2d528898f7
lib: move multibyte.[ch] to curlx/
...
This file provides functions in the curlx set.
Closes #17285
2025-05-08 10:19:19 +02:00
Stefan Eissing
f7057760eb
telnet: keep protocol struct at easy handle meta
...
Remove the member of data->req.p
Closes #17271
2025-05-08 09:30:56 +02:00
Daniel Stenberg
40ef77b6da
headers: enforce a max number of response header to accept
...
The limit is 5000 headers in a single transfer. To avoid problems caused
by mistakes or malice.
Add test 747 to verify
Reported-by: wolfsage on hackerone
Closes #17281
2025-05-08 08:17:56 +02:00
Daniel Stenberg
d689bd915e
src: rename curlx_safefree to tool_safefree
...
It is not part of the curlx function collection, just a macro that might
as well be a local version.
Closes #17270
2025-05-08 08:16:44 +02:00
Daniel Stenberg
613436dbbb
netrc: avoid NULL deref on weird input
...
A dynbuf that never gets populated might return a NULL, and Coverity
could find a way through like that.
Closes #17275
2025-05-07 17:15:39 +02:00
Stefan Eissing
412d3c3dc9
ldap: move easy handle protocol struct into meta hash
...
Removing the member of data->req.p
Closes #17269
2025-05-07 17:13:03 +02:00
Daniel Stenberg
3a2689712a
vtls: avoid NULL deref on bad PEM input
...
Spotted by Coverity
Closes #17274
2025-05-07 17:08:06 +02:00
Stefan Eissing
7b92844639
smtp: use easy handle/connectin meta for proto structs
...
Move `struct smtp_conn` and `struct STMP` into the meta data at easy
handle/connection. Remove it from the unions at connectdata and request.
Closes #17257
2025-05-07 16:01:05 +02:00
Daniel Stenberg
cf38e0067c
metahash: add asserts to help analyzers
...
Where NULL pointers are not acceptable input.
Closes #17268
2025-05-07 11:25:14 +02:00
Daniel Stenberg
255aac56f9
curlx: move into to curlx/
...
Move curlx_ functions into its own subdir.
The idea is to use the curlx_ prefix proper on these functions, and use
these same function names both in tool, lib and test suite source code.
Stop the previous special #define setup for curlx_ names.
The printf defines are now done for the library alone. Tests no longer
use the printf defines. The tool code sets its own defines. The printf
functions are not curlx, they are publicly available.
The strcase defines are not curlx_ functions and should not be used by
tool or server code.
dynbuf, warnless, base64, strparse, timeval, timediff are now proper
curlx functions.
When libcurl is built statically, the functions from the library can be
used as-is. The key is then that the functions must work as-is, without
having to be recompiled for use in tool/tests. This avoids symbol
collisions - when libcurl is built statically, we use those functions
directly when building the tool/tests. When libcurl is shared, we
build/link them separately for the tool/tests.
Assisted-by: Jay Satiro
Closes #17253
2025-05-07 11:01:15 +02:00
Stefan Eissing
17e13cba62
imap: use easy handle/connection meta for proto structs
...
Remove the imap protocol structs from connectdata->proto union
and data->req.p and use the easy handle/connection meta hash
for keeping them.
Closes #17261
2025-05-07 10:25:18 +02:00
Stefan Eissing
2e49965126
rtsp: move easy handle/connection protoocol structs into meta data
...
Remove the connectdata proto and data->req.p member for rtsp and manage
the structs as meta data at easy handle/connection.
Closes #17254
2025-05-06 17:13:24 +02:00
Daniel Stenberg
f7c544d867
pop3: add null pointer check
...
Pointed out by Coverity. A precaution to catch internal errors.
Follow-up to 76d13c721bCloses #17255
2025-05-06 17:11:25 +02:00
Stefan Eissing
a30830db78
ftp: fix bug in failed init
...
torture tests revealed that memory was not released correctly when FTP's
connection setup failed an allocation.
Follow-up from a2d90d4ba5Closes #17258
2025-05-06 13:22:12 +02:00
Stefan Eissing
777c5209df
smb: use easy handle/connection meta hash to keep structs
...
Keep easy/connection related protoocl structs in the meta hash instead
of the unions at request and connectdata.
Closes #17238
2025-05-06 09:10:07 +02:00
Stefan Eissing
cd3be116b6
rtmp: use connection meta for RTMP* instance
...
Keep RTMP* instance at connection meta hash.
Closes #17237
2025-05-06 09:09:21 +02:00
Stefan Eissing
76d13c721b
pop3: use meta hashes at easy handle and connection
...
Keep the pop3 related protocol information in the meta hashes at easy
handle and connection.
Move the struct definitions inside pop3.c
Closes #17236
2025-05-06 09:08:47 +02:00
Stefan Eissing
a2d90d4ba5
ftp: use easy handle and connectin meta data for protocol structs
...
- remove data->req.p.ftp and store `struct FTP` as easy meta data
- place `struct ftp_conn` instance in connection meta data
Closes #17249
2025-05-06 09:07:43 +02:00
Stefan Eissing
378aa011e6
tftp: use connections meta hash
...
Use connection meta hash for state struct instead of union pointer at
connectdata.
Closes #17235
2025-05-06 09:05:27 +02:00
Stefan Eissing
d57bdbf830
openldap: use connection meta for context struct
...
Remove member of conn->proto union.
Closes #17224
2025-05-06 09:04:01 +02:00
Viktor Szakats
838dc53bb7
spacecheck.pl: check for non-ASCII chars, fix fallouts
...
Reported-by: James Fuller
Assisted-by: Dan Fandrich
Closes #17247
2025-05-04 17:26:11 +02:00
Andrei Florea
a638828c88
TLS: add CURLOPT_SSL_SIGNATURE_ALGORITHMS and --sigalgs
...
Fixes #12982
Closes #16964
2025-04-30 17:47:22 +02:00
Viktor Szakats
3fcddc835c
scripts: fix perl indentation, whitespace, semicolons
...
Ref: #17116
Closes #17209
2025-04-29 19:35:55 +02:00
Corinna Brandt
ea897fddfc
openssl: set the cipher string before doing private cert
...
... as this allows a set string to affect how OpenSSL deals with the
private keys/certs.
Closes #17227
2025-04-29 16:17:48 +02:00
Stefan Eissing
47b2300192
mqtt: use conn/easy meta hash
...
Remove mqtt structs from the unions at connectdata and
easy handle requests. Use meta hash at easy/connnection.
Make mqtt structs private to mqtt.c
Closes #17221
2025-04-29 14:25:25 +02:00
Daniel Stenberg
e383ba53eb
multi_ev: remove redundant check for data
...
Pointed out by CodeSonar
Closes #17226
2025-04-29 14:22:31 +02:00
Stefan Eissing
f0824d1ed7
meta data handling for easy/conn fixes
...
- return error when adding to hash fails
- do not free passed in data, as ownership is taken by call
Closes #17219
2025-04-29 13:57:16 +02:00
Daniel Stenberg
2fa3d528ae
openssl: first unload the provider, then free the context
...
Doing it in the reversed order causes bad problems inside OpenSSL.
Closes #17223
2025-04-29 12:45:23 +02:00
