2 Commits

Author	SHA1	Message	Date
Viktor Szakats	578ee6b79b	gcc: guard #pragma diagnostic in core code for <4.6, disable picky warnings ... Extend `#pragma diagnostic push`/`pop` guards to the whole codebase (from tests and examples only) to disable it for GCC <4.6. Rename guard to `CURL_HAVE_DIAG` and make it include llvm/clang to be interchangeable with `__GNUC__ || __clang__` in this context. The above means no longer disabling certain warnings locally, so pair this with disabling all picky warnings for GCC <4.6. Also: - drop global workarounds for misbehaving GCC <4.6 compiler warnings. Not needed with picky warnings disabled. Reported-by: fds242 on github Reported-by: Sergey Fedorov Thanks-to: Orgad Shaneh Follow-up to f07a98ae11 #20366 Fixes #20892 Fixes #20924 Closes #20902 Closes #20907	2026-03-18 11:33:37 +01:00
Viktor Szakats	64f28b8f88	curlx: add local snprintf() helper that always nul-terminates (Windows) ... Make the helper use `vsnprintf()` internally on all supported Windows toolchains (dropping `_snprintf()` and `snprintf()`), ensure to nul-terminate. Omit the return value to avoid complexity. Use the helper from `mprintf.c` / `out_double()`, from tests/server code and the tests/server-specific build of `curlx_inet_ntop()`, `curlx_strerror()` functions. In the single call (in tests) where the returned length was used previously, determine it with `strlen()`. Refs: https://github.com/libssh2/libssh2/blob/libssh2-1.11.1/src/misc.c#L57-L79 https://learn.microsoft.com/cpp/c-runtime-library/reference/snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l https://learn.microsoft.com/cpp/c-runtime-library/reference/vsnprintf-vsnprintf-vsnprintf-l-vsnwprintf-vsnwprintf-l Assisted-by: Jay Satiro Follow-up to fa8bd1cc09 #20761 Follow-up to 8ab468c8aa #15997 Closes #20765	2026-03-02 21:30:36 +01:00