From ecd09257d8643bbe4a06da1ac5d77352db6a0366 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Mon, 6 Apr 2026 17:09:10 +0200 Subject: [PATCH] GHA/curl-for-win: drop certdata dependency and `GITHUB_TOKEN` with it `certdata` dependency requires accessing api.github.com for a reproducible timestamp, which in turn requires a GitHub token to avoid errors due to rate limiting. Avoid all this by omitting this dependency, which isn't necessary for these build tests anyway. The `zero` job already did not use `certdata`, but disable explicitly anyway just in case. Reported-by: James Fuller Follow-up to https://github.com/curl/curl-for-win/commit/9514184977347dbfcd7a4f48daeda7bdb8222458 Follow-up to 128c252975423856d1403c42267a8a1f1b97433f #21105 Closes #21241 --- .github/workflows/curl-for-win.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/curl-for-win.yml b/.github/workflows/curl-for-win.yml index b6e51d2309..74a81f7e55 100644 --- a/.github/workflows/curl-for-win.yml +++ b/.github/workflows/curl-for-win.yml @@ -32,7 +32,6 @@ concurrency: permissions: {} env: - GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}' CW_NOGET: 'curl trurl' CW_MAP: '0' CW_JOBS: '5' @@ -53,7 +52,7 @@ jobs: run: | git clone --depth 1 https://github.com/curl/curl-for-win mv curl-for-win/* . - export CW_CONFIG='-main-werror-unitybatch-linux-a64-x64-gcc' + export CW_CONFIG='-main-werror-unitybatch-nocertdata-linux-a64-x64-gcc' export CW_REVISION="${GITHUB_SHA}" . ./_versions.sh export CW_CCSUFFIX='-15' @@ -82,7 +81,7 @@ jobs: run: | git clone --depth 1 https://github.com/curl/curl-for-win mv curl-for-win/* . - export CW_CONFIG='-main-werror-unitybatch-prefill-zero-osnotls-osnoidn-nohttp-nocurltool-linux-x64-gcc' + export CW_CONFIG='-main-werror-unitybatch-nocertdata-prefill-zero-osnotls-osnoidn-nohttp-nocurltool-linux-x64-gcc' export CW_REVISION="${GITHUB_SHA}" . ./_versions.sh sudo podman image trust set --type reject default @@ -109,7 +108,7 @@ jobs: run: | git clone --depth 1 https://github.com/curl/curl-for-win mv curl-for-win/* . - export CW_CONFIG='-main-werror-unitybatch-linux-musl-r64-x64' + export CW_CONFIG='-main-werror-unitybatch-nocertdata-linux-musl-r64-x64' export CW_REVISION="${GITHUB_SHA}" . ./_versions.sh sudo podman image trust set --type reject default @@ -138,7 +137,7 @@ jobs: run: | git clone --depth 1 https://github.com/curl/curl-for-win mv curl-for-win/* . - export CW_CONFIG='-main-werror-cares-unitybatch-mac-x64' + export CW_CONFIG='-main-werror-unitybatch-nocertdata-mac-x64-cares' export CW_REVISION="${GITHUB_SHA}" sh -c ./_ci-mac-homebrew.sh @@ -156,7 +155,7 @@ jobs: run: | git clone --depth 1 https://github.com/curl/curl-for-win mv curl-for-win/* . - export CW_CONFIG='-main-werror-unitybatch-win-x64-noWINE' + export CW_CONFIG='-main-werror-unitybatch-nocertdata-win-x64-noWINE' export CW_REVISION="${GITHUB_SHA}" . ./_versions.sh sudo podman image trust set --type reject default @@ -183,7 +182,7 @@ jobs: run: | git clone --depth 1 https://github.com/curl/curl-for-win mv curl-for-win/* . - export CW_CONFIG='-main-werror-unitybatch-win-x64-gcc-zlibold-noWINE' + export CW_CONFIG='-main-werror-unitybatch-nocertdata-win-x64-gcc-zlibold-noWINE' export CW_REVISION="${GITHUB_SHA}" . ./_versions.sh sudo podman image trust set --type reject default