git-market/curl-curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-11 12:01:42 +08:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity

base64: make base64_encode() error on too long input

Browse Source 
The maximum size is set to 16MB.

It should not possible to call this function with this large input, but
this is a precaution to catch mistakes and replaces the earlier check on
architectures with small size_t.

Closes #19280
This commit is contained in:
Daniel Stenberg 2025-10-30 11:32:15 +01:00
parent 80258309b2
commit c5de083bcc
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/curlx/base64.c
View File

@ -184,10 +184,10 @@ static CURLcode base64_encode(const char *table64,
if(!insize)
return CURLE_OK;
#if SIZEOF_SIZE_T == 4
if(insize > UINT_MAX/4)
return CURLE_OUT_OF_MEMORY;
#endif
/* safety precaution */
DEBUGASSERT(insize <= CURL_MAX_BASE64_INPUT);
if(insize > CURL_MAX_BASE64_INPUT)
return CURLE_TOO_LARGE;
base64data = output = malloc((insize + 2) / 3 * 4 + 1);
if(!output)

4
lib/curlx/base64.h
View File

@ -33,4 +33,8 @@ CURLcode curlx_base64_decode(const char *src,
extern const char Curl_base64encdec[];
/* maximum input length acceptable to base64 encode, here to catch and prevent
mistakes */
#define CURL_MAX_BASE64_INPUT 16000000
#endif /* HEADER_CURL_BASE64_H */