git-market/curl-curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-11 12:01:42 +08:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity

http_aws_sigv4: cannot be used for proxy

Browse Source 
Make sure it is never attempted.

Reported-by: Philippe Antoine
Closes #16569
This commit is contained in:
Daniel Stenberg 2025-03-05 10:55:56 +01:00
parent 34cbf95267
commit c4cd0ae9ba
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/http.c
View File

@ -634,9 +634,10 @@ output_auth_headers(struct Curl_easy *data,
(void)path;
#endif
#ifndef CURL_DISABLE_AWS
if(authstatus->picked == CURLAUTH_AWS_SIGV4) {
if((authstatus->picked == CURLAUTH_AWS_SIGV4) && !proxy) {
/* this method is never for proxy */
auth = "AWS_SIGV4";
result = Curl_output_aws_sigv4(data, proxy);
result = Curl_output_aws_sigv4(data);
if(result)
return result;
}

5
lib/http_aws_sigv4.c
View File

@ -569,7 +569,7 @@ static CURLcode canon_query(struct Curl_easy *data,
}
CURLcode Curl_output_aws_sigv4(struct Curl_easy *data, bool proxy)
CURLcode Curl_output_aws_sigv4(struct Curl_easy *data)
{
CURLcode result = CURLE_OUT_OF_MEMORY;
struct connectdata *conn = data->conn;
@ -605,9 +605,6 @@ CURLcode Curl_output_aws_sigv4(struct Curl_easy *data, bool proxy)
unsigned char sign1[CURL_SHA256_DIGEST_LENGTH] = {0};
char *auth_headers = NULL;
DEBUGASSERT(!proxy);
(void)proxy;
if(Curl_checkheaders(data, STRCONST("Authorization"))) {
/* Authorization already present, Bailing out */
return CURLE_OK;

2
lib/http_aws_sigv4.h
View File

@ -26,6 +26,6 @@
#include "curl_setup.h"
/* this is for creating aws_sigv4 header output */
CURLcode Curl_output_aws_sigv4(struct Curl_easy *data, bool proxy);
CURLcode Curl_output_aws_sigv4(struct Curl_easy *data);
#endif /* HEADER_CURL_HTTP_AWS_SIGV4_H */