git-market/curl-curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-11 12:01:42 +08:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity

hostip: only store negative response for CURLE_COULDNT_RESOLVE_HOST

Browse Source 
Follow-up from ce06fe7771

This allows us to drop the 'keep_negative' variable completely.

Closes #19701
This commit is contained in:
Daniel Stenberg 2025-11-25 23:03:33 +01:00
parent 4701a6d2ae
commit 31b1527c1d
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/hostip.c
View File

@ -806,7 +806,6 @@ CURLcode Curl_resolv(struct Curl_easy *data,
struct Curl_addrinfo *addr = NULL;
bool respwait = FALSE;
size_t hostname_len;
bool keep_negative = TRUE; /* cache a negative result */
CURLcode result = CURLE_COULDNT_RESOLVE_HOST;
*entry = NULL;
@ -858,7 +857,6 @@ CURLcode Curl_resolv(struct Curl_easy *data,
data->set.resolver_start_client);
Curl_set_in_callback(data, FALSE);
if(st) {
keep_negative = FALSE;
result = CURLE_ABORTED_BY_CALLBACK;
goto error;
}
@ -928,7 +926,6 @@ out:
if(dns)
/* avoid a dangling pointer to addr in the dying dns entry */
dns->addr = NULL;
keep_negative = FALSE;
result = CURLE_OUT_OF_MEMORY;
goto error;
}
@ -947,7 +944,7 @@ error:
if(dns)
Curl_resolv_unlink(data, &dns);
Curl_async_shutdown(data);
if(keep_negative)
if(result == CURLE_COULDNT_RESOLVE_HOST)
store_negative_resolve(data, hostname, port);
DEBUGASSERT(result);
return result;