git-market/axios-axios
1
0
Fork 0
mirror of https://github.com/axios/axios.git synced 2026-04-11 14:21:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Modifying isURLSearchParams function to use instanceof instead of duck typing

Browse Source
This commit is contained in:
Nick Uraltsev 2016-05-18 18:47:34 -07:00
parent f20490eb6b
commit 2b8d89a65e
4 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/utils.js
View File

@ -149,15 +149,7 @@ function isStream(val) {
* @returns {boolean} True if value is a URLSearchParams object, otherwise false
*/
function isURLSearchParams(val) {
// Object.prototype.toString will return [object Object] for a polyfill
// Hence, we have to use duck typing
return toString.call(val) === '[object URLSearchParams]' || (
isObject(val) &&
isFunction(val.append) &&
isFunction(val.delete) &&
isFunction(val.get) &&
isFunction(val.set)
);
return typeof URLSearchParams !== 'undefined' && val instanceof URLSearchParams;
}
/**

3
test/specs/__helpers.js
View File

@ -1,6 +1,9 @@
// Polyfill ES6 Promise
require('es6-promise').polyfill();
// Polyfill URLSearchParams
URLSearchParams = require('url-search-params');
// Import axios
axios = require('../../index');

2
test/specs/requests.spec.js
View File

@ -1,5 +1,3 @@
var URLSearchParams = require('url-search-params');
describe('requests', function () {
beforeEach(function () {
jasmine.Ajax.install();

1
test/specs/utils/isX.spec.js
View File

@ -1,6 +1,5 @@
var utils = require('../../../lib/utils');
var Stream = require('stream');
var URLSearchParams = require('url-search-params');
describe('utils::isX', function () {
it('should validate Array', function () {